search

derailed / k9s

🐶 Kubernetes CLI To Manage Your Clusters In Style!
https://k9scli.io
Apache License 2.0
26.95k stars 1.69k forks source link

Dialog boxes are not using the dialog style #2149

Open placintaalexandru opened 1 year ago

placintaalexandru commented 1 year ago




Describe the bug Some dialog boxes do not use the colours. An example is the scale_extender, which shows the button colour as white when you want to scale a resource. i don't know what I'm clickoing:

image

To Reproduce Steps to reproduce the behavior:

I was able to identify the following components that have the issue"

  1. internal/view/scale_extender.go:

    • go to any deployment or stateful set
    • press s to open the <Scale> dialog
    • play with the Ok and Cancel and you will notice the cursor has the same colour as the choice label so you don't know what you choose
    • ss: image

  2. internal/view/rs.go:

    • go to any replica set
    • press CTRL+L to open the rollback dialog
    • ss: image

  3. internal/view/pf.go:

    • create a port-forward to a pod: SHIFT+f on any pod
    • go to port-forward view
    • delete any port-forward: CTRL+d
    • ss: image

  4. internal/view/image_extender.go:

    • go to any deployment
    • press i to set the image
    • ss: image

  5. internal/view/cronjob.go

    • go to cronjob view
    • press s to suspend any cronjob
    • ss: image

  6. internal/view/context.go:

    • go to context view
    • rename any context: press r
    • ss: image

Expected behavior I want the form colours to be set correctly with colours from the skin.yaml file. A fixed version would show the form like this (now I can see what I'm clicking and the colour of the form label changed to not be hardcoded):

image

Screenshots If applicable, add screenshots to help explain your problem.

Versions (please complete the following information):

Additional context Add any other context about the problem here.

sarg3nt commented 5 months ago

@derailed as someone with bad eyes, this is super annoying. The skin I'm using make the dialog buttons really hard to see and this bug has been open a while. Any chance it will get fixed soon?

placintaalexandru commented 5 months ago

Hello @sarg3nt I tried to ask the maintainer on the official slack channel. Maybe it's worth going there as well and ask again. This way people would see there is some interest for this