search

derat / yambs

Moved to codeberg.org/derat/yambs
https://codeberg.org/derat/yambs
BSD 3-Clause "New" or "Revised" License
4 stars 0 forks source link

Artist MBID lookup failed due to multiple relations #24

Closed derat closed 1 year ago

derat commented 1 year ago

The artist MBID wasn't found while I was seeding https://mpsc.bandcamp.com/album/days-as-echoes. I see this in the logs:

Failed getting artist MBID from https://mpsc.bandcamp.com/: got 3 relations for URL

There's already a TODO in mbdb/db.go about figuring out how to handle this case.

derat commented 1 year ago

Here's the XML from https://musicbrainz.org/ws/2/url?resource=https%3A%2F%2Fmpsc.bandcamp.com%2F&inc=artist-rels (after manual reformatting):

<?xml version="1.0" encoding="UTF-8"?>
<metadata xmlns="http://musicbrainz.org/ns/mmd-2.0#">
  <url id="726abe3f-03e8-479a-8fff-237be75b78e9">
    <resource>https://mpsc.bandcamp.com/</resource>
    <relation-list target-type="artist">
      <relation type="bandcamp" type-id="c550166e-0548-4a18-b1d4-e2ae423a3e88">
        <target>4e1a1a2c-32c5-4013-9264-61b92e06b7d4</target>
        <direction>backward</direction>
        <artist id="4e1a1a2c-32c5-4013-9264-61b92e06b7d4" type="Group" type-id="e431f5f6-b5d2-343d-8b36-72607fffb74b">
          <name>Hanz Mambo &amp; his Cigarettes</name>
          <sort-name>Hanz Mambo &amp; his Cigarettes</sort-name>
          <disambiguation>aka Misha Panfilov Sound Combo</disambiguation>
        </artist>
      </relation>
      <relation type="bandcamp" type-id="c550166e-0548-4a18-b1d4-e2ae423a3e88">
        <target>c6d215c4-c718-4bb6-a54a-4c1eee8bc068</target>
        <direction>backward</direction>
        <artist id="c6d215c4-c718-4bb6-a54a-4c1eee8bc068" type="Group" type-id="e431f5f6-b5d2-343d-8b36-72607fffb74b">
          <name>Misha Panfilov Sound Combo</name>
          <sort-name>Misha Panfilov Sound Combo</sort-name>
        </artist>
      </relation>
      <relation type="bandcamp" type-id="c550166e-0548-4a18-b1d4-e2ae423a3e88">
        <target>eef9b345-2daa-4209-b595-a3e290335f64</target>
        <direction>backward</direction>
        <artist id="eef9b345-2daa-4209-b595-a3e290335f64" type="Person" type-id="b6e035f4-3ce9-331c-97df-83397230b0df">
          <name>Misha Panfilov</name>
          <sort-name>Panfilov, Misha</sort-name>
        </artist>
      </relation>
    </relation-list>
  </url>
</metadata>

Maybe I should just choose the MBID corresponding to the name that's closest to the artist name from Bandcamp.