derceg / explorerplusplus

Explorer++ is a lightweight and fast file manager for Windows
https://explorerplusplus.com
GNU General Public License v3.0
2.5k stars 359 forks source link

Dark theme #115

Open 2E0PGS opened 6 years ago

2E0PGS commented 6 years ago

I think it would be awesome to have a dark theme.

Perhaps I will see what the codebase is like and what GUI framework it uses then make a pull-request adding the feature.

rossunger commented 2 years ago

MSPaint or any image editing software. To clarify, this is if you're building from source...

T3chminator commented 2 years ago

ah, i'd not know how to build from source.

RopoTrop commented 2 years ago

This is the link for the latest:

https://ci.appveyor.com/project/derceg/explorerplusplus/build/job/xefra9t0nxe087aw/artifacts

But you just need to go to:

https://ci.appveyor.com/project/derceg/explorerplusplus/

And navigate from there.

I'm unable to access download link... "Artifacts older than 1 month are automatically deleted."

cinematic6436 commented 2 years ago

This is the link for the latest: https://ci.appveyor.com/project/derceg/explorerplusplus/build/job/xefra9t0nxe087aw/artifacts But you just need to go to: https://ci.appveyor.com/project/derceg/explorerplusplus/ And navigate from there.

I'm unable to access download link... "Artifacts older than 1 month are automatically deleted."

I can't download it either. Would someone be able to host the executable so those of us late to the party can get it, too?

rossunger commented 2 years ago

Here's a version I compiled today with the settings that I use: https://we.tl/t-qMjC0OTjWB I tweaked the tree-veiw:

and I changed the "folder is empty" to not be white

I'm trying to tweak the tab headings and the filemenu not working in dark mode, but I'm not experienced at ALL with win32 windows programming so I'm not making a lot of progress

T3chminator commented 2 years ago

Here's a version I compiled today with the settings that I use: https://we.tl/t-qMjC0OTjWB I tweaked the tree-veiw:

* increased the intend amount

* increased the height of each item

* made it so you can click anywhere along the width of each item to select it  (not just the text)

and I changed the "folder is empty" to not be white

I'm trying to tweak the tab headings and the filemenu not working in dark mode, but I'm not experienced at ALL with win32 windows programming so I'm not making a lot of progress

I just tried it but it's not made any difference? Am I supposed to uninstall the previous version first before running this? I though to ask first before doing it since I'd have to configure all the settings over again.

cinematic6436 commented 2 years ago

Here's a version I compiled today with the settings that I use: https://we.tl/t-qMjC0OTjWB I tweaked the tree-veiw:

* increased the intend amount

* increased the height of each item

* made it so you can click anywhere along the width of each item to select it  (not just the text)

and I changed the "folder is empty" to not be white

I'm trying to tweak the tab headings and the filemenu not working in dark mode, but I'm not experienced at ALL with win32 windows programming so I'm not making a lot of progress

Thanks! It's working beautifully now. I'm using this as program strictly for windows for shortcuts with extra-large icons only. Now I don't have to look at the ugly navigation pane on the left, which I haven't been able to do since Windows XP!

Is there any way to adjust the background color so it's completely black instead of dark grey? Also, it looks like a row of extra large icons should stretch six wide instead of five. Is there anything I'm doing wrong that's preventing this from happening? Or is there a way to adjust the horizontal gaps so everything's evenly spaced?

Regardless, thanks so much for your help!

cinematic6436 commented 2 years ago

Here's a version I compiled today with the settings that I use: https://we.tl/t-qMjC0OTjWB I tweaked the tree-veiw:

* increased the intend amount

* increased the height of each item

* made it so you can click anywhere along the width of each item to select it  (not just the text)

and I changed the "folder is empty" to not be white I'm trying to tweak the tab headings and the filemenu not working in dark mode, but I'm not experienced at ALL with win32 windows programming so I'm not making a lot of progress

I just tried it but it's not made any difference? Am I supposed to uninstall the previous version first before running this? I though to ask first before doing it since I'd have to configure all the settings over again.

I just overwrote the original executable. I also added the following to my shortcut:

"C:\Program Files\Explorer++\Explorer++.exe" --enable-dark-mode

T3chminator commented 2 years ago

Here's a version I compiled today with the settings that I use: https://we.tl/t-qMjC0OTjWB I tweaked the tree-veiw:

* increased the intend amount

* increased the height of each item

* made it so you can click anywhere along the width of each item to select it  (not just the text)

and I changed the "folder is empty" to not be white I'm trying to tweak the tab headings and the filemenu not working in dark mode, but I'm not experienced at ALL with win32 windows programming so I'm not making a lot of progress

I just tried it but it's not made any difference? Am I supposed to uninstall the previous version first before running this? I though to ask first before doing it since I'd have to configure all the settings over again.

I just overwrote the original executable. I also added the following to my shortcut:

"C:\Program Files\Explorer++\Explorer++.exe" --enable-dark-mode

Same thing, not working.

rossunger commented 2 years ago

Here's a version I compiled today with the settings that I use: https://we.tl/t-qMjC0OTjWB I tweaked the tree-veiw:

* increased the intend amount

* increased the height of each item

* made it so you can click anywhere along the width of each item to select it  (not just the text)

and I changed the "folder is empty" to not be white I'm trying to tweak the tab headings and the filemenu not working in dark mode, but I'm not experienced at ALL with win32 windows programming so I'm not making a lot of progress

I just tried it but it's not made any difference? Am I supposed to uninstall the previous version first before running this? I though to ask first before doing it since I'd have to configure all the settings over again.

I just overwrote the original executable. I also added the following to my shortcut: "C:\Program Files\Explorer++\Explorer++.exe" --enable-dark-mode

Same thing, not working.

What version of windows are you on? I believe older versions don't have dark mode... other than that I'm not sure what the issue might be! if you downloaded the exe and xml config file, it should just start in dark mode.

T3chminator commented 2 years ago

I'm on windows 10. I have the dark mode. it's just about the empty folder white patch

derceg commented 2 years ago

This is the link for the latest: https://ci.appveyor.com/project/derceg/explorerplusplus/build/job/xefra9t0nxe087aw/artifacts But you just need to go to: https://ci.appveyor.com/project/derceg/explorerplusplus/ And navigate from there.

I'm unable to access download link... "Artifacts older than 1 month are automatically deleted."

I've rebuilt the latest commit.

I haven't had the chance to look at it yet, but one of the things I'll do when I work on the application again is to sort out some alternative, longer term storage, for development builds. That should then fix the recurring issue of builds being deleted after only a month.

cinematic6436 commented 2 years ago

This is the link for the latest: https://ci.appveyor.com/project/derceg/explorerplusplus/build/job/xefra9t0nxe087aw/artifacts But you just need to go to: https://ci.appveyor.com/project/derceg/explorerplusplus/ And navigate from there.

I'm unable to access download link... "Artifacts older than 1 month are automatically deleted."

I've rebuilt the latest commit.

I haven't had the chance to look at it yet, but one of the things I'll do when I work on the application again is to sort out some alternative, longer term storage, for development builds. That should then fix the recurring issue of builds being deleted after only a month.

Thanks for the commit and making this program in the first place.

Is is possible to adjust horizontal and vertical icon spacing on my own? I'd also like to make the background black instead of dark grey. I searched config.xml but couldn't find anything related to either.

HelgenX commented 2 years ago

There's something really wrong with these files. If I use the xml with the modified e++, it starts maximized, and if I click to make it windowed, it goes off the screen and I have to ALT+F4 it. Also, it doesn't remember window position or last folder visited.

ThisNekoGuy commented 2 years ago

Hope this and theming get implemented soon; I'd use Explorer++ if it didn't feel like it came from Windows 2003 :/ Instead, I'm using Clover 3 (despite my preference for open-source software) Is this close to being implemented?

anonymous1184 commented 2 years ago

@ThisNekoGuy be careful with Clover as it contains a lot of unwanted stuff, keep only the bare essentials and you'll be fine (I've tested and monitored).

Explorer++ with the Dark theme while not perfect is a pretty solid replacement for Windows Explorer.

dave-ostroske-at-microbac commented 2 years ago

@ThisNekoGuy be careful with Clover as it contains a lot of unwanted stuff

By that, I assume, you're referring to the fact that Clover reports back to its creators when you use it. It could be telemetry, or it could be the project spying on its users. Either way, it's a surefire way to fracture an open-source project, which Clover has never been.

anonymous1184 commented 2 years ago

@dave-ostroske-at-microbac it has lots of bundleware and at least in my limited testing reaches out to google-analytics.com (among other weird domains I can't recall).

What I do is pretty strength-forward: take a snapshot of my system, install and copy the needed files then rollback before the installation. Now with the required files/folders:

Open an elevated terminal and register the DLLs:

regsvr32 TabHelper32.dll
regsvr32 TabHelper64.dll

That way seems to be usable (v3.5.4.20416 on W10 Pro x64 21H2). Another measure is to add an outbound firewall rule for the process, but I haven't seen any weird domains in my DNS logs (can't hurt tho).


Then again, I'm more into Explorer++ the last version usable for me is 1.4.0.1849 (7/9/21) as newer tend to bug with large number of files and keep randomly blanking the columns. For this wonderful app to be mainstream just needs a proper Dark mode, a switch in the options and links to current versions as all the people I ever recommended think the project is dead because the stable version is 9 years old and the beta is 2 years old.

suaracahaya commented 2 years ago

Here's a version I compiled today with the settings that I use: https://we.tl/t-qMjC0OTjWB I tweaked the tree-veiw:

  • increased the intend amount
  • increased the height of each item
  • made it so you can click anywhere along the width of each item to select it (not just the text)

and I changed the "folder is empty" to not be white

I'm trying to tweak the tab headings and the filemenu not working in dark mode, but I'm not experienced at ALL with win32 windows programming so I'm not making a lot of progress

Sadly the link has "expired" :') Is there anyone who could help uploading the darkmode explorer++ again please?

Slion commented 2 years ago

Here's a version I compiled today with the settings that I use: https://we.tl/t-qMjC0OTjWB I tweaked the tree-veiw:

  • increased the intend amount
  • increased the height of each item
  • made it so you can click anywhere along the width of each item to select it (not just the text)

and I changed the "folder is empty" to not be white I'm trying to tweak the tab headings and the filemenu not working in dark mode, but I'm not experienced at ALL with win32 windows programming so I'm not making a lot of progress

Sadly the link has "expired" :') Is there anyone who could help uploading the darkmode explorer++ again please?

Tried that? https://github.com/derceg/explorerplusplus/issues/115#issuecomment-975821963

pseudo555 commented 2 years ago

Expect that "last green" build is older than one month, so artefacts were deleted.

On Fri, Apr 1, 2022 at 3:42 PM Stéphane Lenclud @.***> wrote:

Here's a version I compiled today with the settings that I use: https://we.tl/t-qMjC0OTjWB I tweaked the tree-veiw:

  • increased the intend amount
  • increased the height of each item
  • made it so you can click anywhere along the width of each item to select it (not just the text)

and I changed the "folder is empty" to not be white I'm trying to tweak the tab headings and the filemenu not working in dark mode, but I'm not experienced at ALL with win32 windows programming so I'm not making a lot of progress

Sadly the link has "expired" :') Is there anyone who could help uploading the darkmode explorer++ again please?

Tried that: #115 (comment) https://github.com/derceg/explorerplusplus/issues/115#issuecomment-975821963

— Reply to this email directly, view it on GitHub https://github.com/derceg/explorerplusplus/issues/115#issuecomment-1085917847, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEL7PVCD6ZVZKL5C3RYZV7TVC34L7ANCNFSM4FDMRO5A . You are receiving this because you commented.Message ID: @.***>

pseudo555 commented 2 years ago

My bad, one build just got green: https://ci.appveyor.com/project/derceg/explorerplusplus/builds/43101592 (link available for one month only !)

On Fri, Apr 1, 2022 at 5:37 PM pseudo555 @.***> wrote:

Expect that "last green" build is older than one month, so artefacts were deleted.

On Fri, Apr 1, 2022 at 3:42 PM Stéphane Lenclud @.***> wrote:

Here's a version I compiled today with the settings that I use: https://we.tl/t-qMjC0OTjWB I tweaked the tree-veiw:

  • increased the intend amount
  • increased the height of each item
  • made it so you can click anywhere along the width of each item to select it (not just the text)

and I changed the "folder is empty" to not be white I'm trying to tweak the tab headings and the filemenu not working in dark mode, but I'm not experienced at ALL with win32 windows programming so I'm not making a lot of progress

Sadly the link has "expired" :') Is there anyone who could help uploading the darkmode explorer++ again please?

Tried that: #115 (comment) https://github.com/derceg/explorerplusplus/issues/115#issuecomment-975821963

— Reply to this email directly, view it on GitHub https://github.com/derceg/explorerplusplus/issues/115#issuecomment-1085917847, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEL7PVCD6ZVZKL5C3RYZV7TVC34L7ANCNFSM4FDMRO5A . You are receiving this because you commented.Message ID: @.***>

T3chminator commented 2 years ago

How to resubscribe to this thread?

anonymous1184 commented 2 years ago

@pseudo555

Thanks for that last build, here's the GitHub hosted mirror (uploaded to this issue) of the x64 artifact:

explorerpp_x64.zip

paulo-roger commented 2 years ago

Please, this would be awesome, white screen apps are unusable nowadays.

pseudo555 commented 2 years ago

Using the appvoyer page : https://ci.appveyor.com/project/derceg/explorerplusplus/history

Look for a valid compilation build (the green one). click on it. In the JOB name part, use the one designed for your OS (x32 ou x64). Then, clic on the Artifact tabs (far right side). Download the zip file.

This always works for build which is LESS than one month old.

if you're too lazy, here is the last one (as of this mail - 1912): x64: https://ci.appveyor.com/api/buildjobs/b0he82qqf400fek4/artifacts/explorerpp_x64.zip x32: https://ci.appveyor.com/api/buildjobs/b1i29ne4x5j69asm/artifacts/explorerpp_x86.zip

On Mon, Jun 20, 2022 at 3:35 PM Shandilya @.***> wrote:

Hi @derceg https://github.com/derceg

Could you please provide link to dark theme build? The links provided earlier are of no use now ?

When are you planning to merge this dark theme changes in master ? I'm currently using this: 1.4.0.1748 beta (64-bit build) but this still doesn't have dark theme feature integrated.

— Reply to this email directly, view it on GitHub https://github.com/derceg/explorerplusplus/issues/115#issuecomment-1160457949, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEL7PVBVN7MOJPLGKGE22R3VQBXRFANCNFSM4FDMRO5A . You are receiving this because you were mentioned.Message ID: @.***>

T3chminator commented 2 years ago

I fucked up... I had set explorer++ to replace the default windows file explorer. I once uninstalled it without first reverting it back to windows default file explorer and since then I cannot open Control Panel of the Default File explorer. The only way to access control panel is to reinstall Explorer++. I have tried many solutions including doing an in place windows 10 upgrade, all suggested by Microsoft support but nothing has worked. I even emailed the creator of this application directly but the email is not going through. Please help.

sean-e commented 2 years ago

After you reinstalled Explorer++, did you try restoring the Default File Manager setting?

T3chminator commented 2 years ago

Yes I did that and uninstalled Explorer++ but the issue persists.

sean-e commented 2 years ago

Sorry, I don't know anything about this issue.
Does restoring default file manager setting work properly before you uninstall Exp++? Did you originally select "Replace explorer for filesystem folders" or "Replace explorer for all folders" ? If I were in your position, I would reinstall Exp++, change the default file mgr setting to what you first selected, reboot, change default file mgr to "don't replace", reboot, confirm things are working as expected, then try uninstall of exp++ only if default file manager is working properly. good luck.

T3chminator commented 2 years ago

Does restoring default file manager setting work properly before you uninstall Exp++? No, because I had uninstalled it without first reverting it back to the default file explorer so now even after reinstalling Explorer++, setting to default file manager and then uninstalling does not help.

Did you originally select "Replace explorer for filesystem folders" or "Replace explorer for all folders" ? Replace explorer for filesystem folders

If I were in your position, I would reinstall Exp++, change the default file mgr setting to what you first selected, reboot, change default file mgr to "don't replace", reboot, confirm things are working as expected, then try uninstall of exp++ only if default file manager is working properly. good luck. Tried that but still no joy.

leminsc8er commented 2 years ago

We are all waiting for a dark mode. Welcome to 2022 (w10)... dont want a awalkaground want a simple option to it... one rison i not use this explorer or beta... @devs my eyes says thanks if you should look for it soon...

WildByDesign commented 2 years ago

@derceg The main thing missing now is the dark theme for the menu bar. That is likely more complicated and therefore take more time to complete. In the meantime, would it be feasible to have an option to hide the menu bar?

If the menu bar could be hidden, Explorer++ would have a thorough dark theme look until the menu bar itself has dark theme applied. Cheers, and thank you for everything that you have done with Explorer++.

T3chminator commented 2 years ago

run the .exe passing "--enable-dark-mode" on the command line: Explorer++.exe --enable-dark-mode

(assuming you are using a recent daily/nightly build)

How to do that?

anonymous1184 commented 2 years ago

@leminsc8er: It's there.


@WildByDesign:

How to do that?

Not needed, it's been a little while since is an option:

Options

Just download the latest build.

Braulioaej commented 2 years ago

@leminsc8er: It's there.

@WildByDesign:

How to do that?

Not needed, it's been a little while since is an option:

(image)

Just download the latest build.

Hello, how'd you get that "Advanced" tab? I don't have one, and haven't found anywhere how to enable it. I'm on 1.4.0 beta 2, using the x64 zip. Cheers.

image

anonymous1184 commented 2 years ago

@Braulioaej Download a more recent version: explorerpp_x64.zip.

tanevanwifferen commented 2 years ago

@Braulioaej Download a more recent version: explorerpp_x64.zip.

Doesn't work for me. Running windows 11 22621.819

Mishasama commented 1 year ago

image The default color for compressed files on the dark theme is unreadable.

i2 commented 1 year ago

@derceg Is it possible to automatically switch between dark and light theme based on Windows theme? In Windows 11, one can have scheduled automated theme switching and some application conform to it and use system theme.

Right now, I have to close Explorer++ so it recognized the updated theme. I am using the latest successfully build (1.4.0.1968) from this link. Thank you!

derceg commented 1 year ago

Is it possible to automatically switch between dark and light theme based on Windows theme? In Windows 11, one can have scheduled automated theme switching and some application conform to it and use system theme.

It's something I'm actively working on at the moment. There are a few different things involved:

  1. Honoring dark mode, even when the system is set to light mode. At the moment, that doesn't work.
  2. Adding a "System default" option that will track whatever is set in Windows.
  3. Dynamically switching between the light and dark themes when either the option is changed in the application, or the system default is changed. That way, the application doesn't have to be restarted for the updated theme to take effect.

1 and 2 are reasonably simple, but 3 is more work. It's definitely feasible, as I have a test implementation at the moment that switches most of the controls between light and dark dynamically.

WildByDesign commented 1 year ago

@derceg Would it be possible to utilize Notepad++ method of achieving dark menubar?

Source: https://github.com/notepad-plus-plus/notepad-plus-plus/blob/master/PowerEditor/src/DarkMode/UAHMenuBar.h

That is used to color the menubar.

I noticed recently that a program that I use, Windhawk, also has a mod (Dark Mode for Notepad) that changes win32 Notepad into dark mode. I checked the code and saw that they also utilized the same UAHMenuBar.h from Notepad++ to color the menubar in the win32 Notepad mod with great success.

Source: https://github.com/ramensoftware/windhawk-mods/blob/main/mods/notepad-dark-mode.wh.cpp#L626

This is the section where win32 Notepad dark mode utilized UAHMenuBar.h to color the menubar.

Although since I am not a programmer, I cannot possible understand how well this would work for Explorer++ implementation.

paradoxicallist commented 1 year ago

@derceg Would it be possible to utilize Notepad++ method of achieving dark menubar?

I second that request, thanks a lot for your hard work @derceg

derceg commented 1 year ago

I'm working on the menu bar at the moment. Thankfully, it's possible to owner-draw the menu bar, using some similar code to that of Notepad++, though without having to use undocumented methods. The menu bar will look like this under dark mode:

image

And like this when an item is selected:

image

The bar will have the same size and font as it normally does, just with different colors.

WildByDesign commented 1 year ago

The latest AppVeyor builds with the new dark menu bar look absolutely fantastic! I've only tested it for a few minutes so far but no issues.

mll0 commented 1 year ago

The latest AppVeyor builds with the new dark menu bar look absolutely fantastic! I've only tested it for a few minutes so far but no issues.

Thanks for the headsup, i hadn't tested it in a while. Is it still that convoluted way to switch to dark, or is there now some easy way that, in spite of my browsing the menus, I can't find ?

WildByDesign commented 1 year ago

Thanks for the headsup, i hadn't tested it in a while. Is it still that convoluted way to switch to dark, or is there now some easy way that, in spite of my browsing the menus, I can't find ?

No problem. There is a new section in Options titled Appearance. You can choose Dark, Light, or System which would do auto dark or light depending on Windows theme.

paradoxicallist commented 1 year ago

On Windows 10 21H2 x64 looks fantastic, let's see how it does on a WinPE...

derceg commented 1 year ago

The latest AppVeyor builds with the new dark menu bar look absolutely fantastic! I've only tested it for a few minutes so far but no issues.

Thanks! The menu bar is now always owner-drawn on Windows 10 and 11, including when dark mode is off and when high contrast themes are used. There are some very minor differences to the stock bar, but the custom bar should look and act the same way as the stock one. If you come across any substantial differences or issues, feel free to raise them here.

On Windows 10 21H2 x64 looks fantastic, let's see how it does on a WinPE...

I actually updated the screenshots on the website a few days ago and included a screenshot from Windows 11 PE with dark mode turned on in the application. You can see it at https://explorerplusplus.com/screenshots. It's currently the last screenshot on the page. While the title bar still uses the default colors, the rest of the application should look about the same as it does on a full installation.

paradoxicallist commented 1 year ago

Here is what looks like version 1908 on win10 : [image: image.png] As you can see, the blue overlay is way less agressive on w10 instead on 11 (where we can say the blue filter is almost cyan).

Your image.png is not displayed, if only you could fix that it would be great.