derceg / explorerplusplus

Explorer++ is a lightweight and fast file manager for Windows
https://explorerplusplus.com
GNU General Public License v3.0
2.48k stars 360 forks source link

Explorer++ crashes after right click #377

Open ehauk opened 1 year ago

ehauk commented 1 year ago

Describe the bug Right clicking on anywhere in the browse window that is not a file or directory on any drive or directory causes a crash after any right click menu selection or clicking off the right click menu without selecting anything.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'explorer++.exe'
  2. Right click on 'anything that is not a file or directory'
  3. Make a selection (view, group by, sort by, etc) or left click off the menu without selecting anything
  4. App crashes and is gone from view and the explorer++.exe process is not running

Expected behavior It should be able to change views and grouping along with all the other features on the right click menu.

Crashes Please attach the associated crash Report.txt dump. This file should be created in %temp% and be named something like Explorer++1.4.0.0-11102020-194414.dmp. Not attaching a crash dump may make it significantly more difficult to diagnose the cause of a crash.

attached windows error report

Screenshots If applicable, add screenshots to help explain your problem.

Version (please complete the following information):

Additional context Version 1.2 works perfectly fine in this respect. No crashes.

eyal282 commented 1 year ago

Same.

Which version should we run then?

derceg commented 1 year ago

Please attach a crash dump from the latest dev build. There's not too much I can do to investigate this without a dump file.

eyal282 commented 1 year ago

Please attach a crash dump from the latest dev build. There's not too much I can do to investigate this without a dump file.

What steps are necessary to attach a crash dump? This is so often I guarantee we have an identical issue.

derceg commented 1 year ago

Trigger the crash using the latest dev build. When the application crashes, it should pop up a dialog showing the path to the crash dump. Attach that file here. Since crashes are inherently unreliable situations, a crash dump might not be generated, in which case the dialog won't show.

eyal282 commented 1 year ago

Trigger the crash using the latest dev build. When the application crashes, it should pop up a dialog showing the path to the crash dump. Attach that file here. Since crashes are inherently unreliable situations, a crash dump might not be generated, in which case the dialog won't show.

The dialog never under any circumstance shows.

It happens on windows 10, and I fixed it by setting compatibility to windows 8. It might point you to the right direction that this is exclusive to windows 10

derceg commented 1 year ago

It's likely an interaction with a shell extension. I can't reproduce the issue on stock Windows 10, for example.

What I'll probably do at some point is provide an option to use a custom context menu, as an alternative to the one provided by the shell. Using a custom menu would completely eliminate crashes like this, but the context menu wouldn't have the same options as the default one. It would still probably be useful in situations like this, though, where there are reliable crashes when using the shell context menu.

eyal282 commented 1 year ago

It's likely an interaction with a shell extension. I can't reproduce the issue on stock Windows 10, for example.

What I'll probably do at some point is provide an option to use a custom context menu, as an alternative to the one provided by the shell. Using a custom menu would completely eliminate crashes like this, but the context menu wouldn't have the same options as the default one. It would still probably be useful in situations like this, though, where there are reliable crashes when using the shell context menu.

Can you make a crash detector that may have false positives, and when it crashes 5 time in 5 hours or something, it'll give the option to toggle it.

Markospoko commented 8 months ago

I confirm that's happening, changing compatibility to windows 8 doesn't help. I downloaded dev version for dump but it doesn't fail there. I have Windows 10.