search

derdilla / blood-pressure-monitor-fl

A cross platform app to save blood pressure values with export function
MIT License
72 stars 15 forks source link

Read weight from bluetooth scale #434

Open pimlie opened 2 months ago

pimlie commented 2 months ago

What you want:

Instead of manually inserting the weight it would be nice if users could connect to a bluetooth scale and read the value from the scale.

It would probably be nice to combine blood pressure & weight into a single measurement using some guided wizard.

Why you want it:

This project could be used as a reference: https://github.com/oliexdev/openScale/wiki/Supported-scales-in-openScale

derdilla commented 2 months ago

I think that thanks to your PR this is a very straight forward feature. If this ends up growing to much we could interface with a dedicated app (like openScale). Android has a health connect api that seems to be designed for this.

I would like to wait with adding anything large like this until the weight feature is stable and got no significant pushback (JohnVeness made me weary of this in 309).

pimlie commented 2 months ago

The main issue with reading bt weights seems to be that there is no official BT weight specification so most manufacturers are using custom services/characteristics for it.

For testing features it would probably be nice to support a beta channel and support auto building PR's

derdilla commented 2 months ago

autobuilding all pr pushes seems like a waste of githubs processing power to me. An action to invoke for users to test on their end (like with exotic ble devices) would be nice. For developers I would heavily recommend properly setting up flutter as this supports hot reload and is really nice to work with imo.

pimlie commented 2 months ago

autobuilding all pr pushes

Afaik you can also configure workflows to require approval by the maintainer (ie you), so you could then decide that f.e. for my big BT pr you want to autobuild it and can toggle the workflow. After you do that, it does mean that the build will trigger on every push to that PR.