derecalliance / protobufs

The format of DeRec messages.
Apache License 2.0
3 stars 0 forks source link

Replace `int*` types with `uint*` where appropriate #24

Closed zanctor closed 8 months ago

zanctor commented 8 months ago

I suggest changing integer types to unsigned ones, where negative values are not expected (key/secret ID, nonce, versions, ParameterRange values, etc). This will double the range of possible values and potentially will make the process of random values generation easier.

jorabin commented 8 months ago

I have a feeling that signed integers were used because of there being no unsigned integer in Java and therefore ending up as a long in the Java protobuf binding.

zanctor commented 8 months ago

Ah, that makes sense. Closing the issue.