search

derecalliance / protobufs

The format of DeRec messages.
Apache License 2.0
3 stars 0 forks source link

GetSecretIdsVersionsRequestMessage is a very long name #3

Closed jorabin closed 11 months ago

jorabin commented 1 year ago

could usefully be made more succinct

jorabin commented 1 year ago

ListSecretsRequestMessage, recommended.

lbaird commented 1 year ago

It needs Get and RequestMessage to follow the standard. Its purpose is to get both secret IDs and version numbers, so I think the name is OK. But if you want to change to GetVersionsRequestMessage, that would be OK. It would be less descriptive, but we can argue it's good enough, since every version needs to also include the secretID.

I'd suggest leaving it as-is. But I'm fine with changing it, if you'd like to add a PR for that. Either way, this issue should be closed.

jorabin commented 11 months ago

I can live without that change