search

derek-adair / nflgame

A working snapshot of nflgame (for historic purposes). This project is no longer active.
http://nflgame.derekadair.com
The Unlicense
331 stars 100 forks source link

urllib -> requests #115

Open derek-adair opened 4 years ago

derek-adair commented 4 years ago

There is a mish-mash of various request libraries used here. I plan on just swapping them all to requests

xabrickx commented 4 years ago

Hey, I'm new to this project and interested in picking this up.

I've "done" the change here https://github.com/derek-adair/nflgame/compare/master...xabrickx:update/115_normalize_requests but didn't want throw PR at you without saying any thing. My change creates simple wrappers for request/response and reroutes the current requests, including the lingering urllib requests, through them.

I'm happy to simplify this and ditch the wrapper if you prefer but thought the benefits of standardizing the requests would outweigh the additional complexity. Please let me know if I've missed anything or you have any recommendations?

derek-adair commented 4 years ago

My change creates simple wrappers for request/response and reroutes the current requests,

Most excellent, this needed doing anyways considering the user-agent string requirement. I'll be looking over this but at a glance it looks very solid.