Incompatible with Django 1.5 due to change from simplejson to json

derek-schaefer / django-json-field

Generic JSON model and form fields.

BSD 3-Clause "New" or "Revised" License

122 stars 86 forks source link

Incompatible with Django 1.5 due to change from simplejson to json #20

Closed jeffbowen closed 11 years ago

jeffbowen commented 11 years ago

django-json-field is incompatible with Django 1.5 due to the switch from simplejson to json. This results in the following error:

TypeError: __init__() got an unexpected keyword argument 'namedtuple_as_object'

I'm not yet familiar enough with django-json-field to know what the right fix is but I'm looking into it. Would love some help from someone with a better understanding.

derek-schaefer commented 11 years ago

Thanks for the heads up, I'll look into this as well. Haven't done any testing with the 1.5 RC's yet.

derek-schaefer commented 11 years ago

One test fails when run under 1.5 RC2 but is otherwise OK. The TypeError only occurs if simplejson has been installed but should be a simple fix. I should be able to fix those problems tomorrow.

jeffbowen commented 11 years ago

Awesome. Thanks @derek-schaefer! For now I just uninstalled simplejson and it's working fine.

derek-schaefer commented 11 years ago

So I fixed this issue about a week ago but a test still fails under Django 1.5 without simplejson installed. It seems that Decimals are being handled differently. In any case, no more errors here!

jeffbowen commented 11 years ago

Thanks @derek-schaefer!