derek57 / sdl-wii

Automatically exported from code.google.com/p/sdl-wii
0 stars 0 forks source link

SDL_INIT_EVERYTHING or SDL_INIT_CDROM fails #4

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. call SDL_Init with SDL_INIT_EVERYTHING or flags | SDL_INIT_CDROM ex:
  if( SDL_Init( SDL_INIT_EVERYTHING ) < 0 )

I except the code to not crash or exist. It is standard to init SDL that
way. I dont think anyone uses or excepts to use the CDRom. No one wants to
write SDL_Init(SDL_INIT_EVERYTHING ^ SDL_INIT_CDROM) or OR the flags by hand.

Please write a stub for the CDROM or make SDL not return < 0 because of it.

Version SDL Wii 04-23-2009.zip.

Original issue reported on code.google.com by mavakada...@gmail.com on 29 Apr 2009 at 11:17

GoogleCodeExporter commented 9 years ago
Did you build SDL from the SVN?  I don't see that CD Rom is supported.

#define SDL_CDROM_DISABLED  1

in SDL_config_wii.h

I'll take a look tonight to see if I can repro.

Original comment by iamsca...@gmail.com on 30 Apr 2009 at 12:23

GoogleCodeExporter commented 9 years ago
No repro in SVN Rev 18.  

SDL_Init with SDL_INIT_EVERYTHING or a combo including SDL_INIT_CDROM returns < 
0. 
You should handle this accordingly like so:

    if ( SDL_Init( SDL_INIT_VIDEO | SDL_INIT_CDROM ) < 0 ) {
        exit(1);
    }

I'm sure CD Rom support will be added but I don't think it's a priority right 
now.

Original comment by iamsca...@gmail.com on 30 Apr 2009 at 4:29

GoogleCodeExporter commented 9 years ago
actually, I think this is a valid issue. We may never add CDROM support (which 
would 
have to be through SD, USB, or DVD anyway), but we should allow the 
SDL_INIT_EVERYTHING flag. I think.

Original comment by dborth@gmail.com on 30 Apr 2009 at 4:43

GoogleCodeExporter commented 9 years ago
I've fixed this issue in SVN. I'm also changing the status to "Fixed".

Fixed is for an issue that has been resolved in SVN but not in a released 
version. 
Completed is when the fix has made it into a released version.

Original comment by dborth@gmail.com on 30 Apr 2009 at 4:50

GoogleCodeExporter commented 9 years ago

Original comment by dborth@gmail.com on 30 Apr 2009 at 4:50

GoogleCodeExporter commented 9 years ago

Original comment by dborth@gmail.com on 14 May 2009 at 5:20