search

derekbeaton / GSVD

19 stars 6 forks source link

*sqrt_psd_matrix() should have tol test #23

Closed derekbeaton closed 4 years ago

derekbeaton commented 4 years ago

these two functions should require a real tol value and shouldn't be allowed to go to the non-numeric pass throughs

effectively, these methods must ensure that the eigenvalues retained are tested to make sure they are positive

derekbeaton commented 4 years ago

I've instead just removed the tol parameter, and enforce it internally for these functions