Closed Dushistov closed 7 years ago
I think for (3) we should have method make
that doesn't force (takes no params), and new method make_force
that forces build. Otherwise looks like something that should be done!
I think for (3) we should have method make that doesn't force (takes no params), and new >method make_force that forces build
In fact, I think that idea of this parameter is great.
I had no such option in my home made analog of depgraph
.
You write rule
, and while you develop method that rule
execute you leave it as force=true
, then you need just change force=false
and developing done.
After that if need some modification in rule, you again force=true
while debugging.
Have one method for force build and another for not force require some reading of documentation, if just one method all things are more simple, in my humble opinion.
If you do a PR for these changes I'll happily make a new version on crates.io :)
I thought about creation of similar crate, but because of your already exists, I think I can use it, but there are several
API inconvenience
for me. Can you consider to improve them?Context:
add_rule
should show in clear way that it deals with file paths, soPath
is clear way to do it, like this:add_rule(input: P, output: &[P]) where P: AsRef<Path>
. This make code also self explainable.make
parameter more clear withenum
, like:make(MakeParams::None)
for me is much more clear, thenmake(false)