derekeder / oak-park-budget

Explore the Village of Oak Park's budget from 2013 to 2021 and learn how the money is being spent.
https://budgetoakpark.com/
Other
2 stars 2 forks source link

Departments hidden when moving between years in graph. #13

Open achastain opened 3 years ago

achastain commented 3 years ago

I think I found a bug. It looks like departments can get hidden when viewing different years. I think what is happening is that the page loads for a year and shows all the departments for that year. If I switch to a year that has more departments than what was displayed when the paged loaded, those new departments don't get added to the table. The table will remove departments if they don't apply to the new year, but not add new ones. For what it's worth, the totals in the graph at the top appear to match regardless of what is included in the table below it.

Steps to reproduce...

  1. Load the website.
  2. Click on 2013 to see the total budget for 2013.
  3. Expand the General Fund in the table. Click through to see the breakdown by departments.
  4. You will see all the departments in the General Fund for 2013. Note that DCS ‐ Business Services is in the middle of the pack on that list.
  5. Click 2021 on the graph. The table will update and DCS ‐ Business Services is removed because the department doesn't have any 2021 expenses.
  6. Click back on 2013 in the graph. The DCS ‐ Business Services department returns to the table.
  7. At the top, click "Oak Park" in the breadcrumb trail. You will be viewing the full budget for 2021 again.
  8. Let's try that path again, but start with 2021 instead of 2013. Expand the General Fund and click through to see the breakdown by departments.
  9. You will see all the departments in the General Fund for 2021. Again, DCS ‐ Business Services is absent because the department doesn't have any 2021 expenses.
  10. Now click 2013 in the graph. The table updates, but it does not include DCS ‐ Business Services even though we know it is there because we saw it when we viewed the departments by 2013 first. That's the bug.
derekeder commented 3 years ago

@achastain thanks - I'll take a look at this.

achastain commented 3 years ago

I just noticed the same thing happens when viewing the entire budget at the fund level too. If I go to the web site and then click on 2015, I see a different set of funds than if I go to the year using its URL (https://budgetoakpark.com/#?year=2015&figures=nominal&breakdown=Fund). 2015-side-by-side