Open derekjxtan opened 9 months ago
No details provided by team.
[The team marked this bug as a duplicate of the following bug]
EMAIL parameter is overly restrictive
Description According to the User Guide,
EMAIL is in the format local-part@domain with a 50-character limit. The domain name must end with a domain label that is supported: gmail, yahoo, outlook, hotmail, icloud.
However, this is overly restrictive. Emails can have local-part sections alone that are up to 64 characters, and there are definitely more domain names that the ones mentioned here, such as
u.nus.edu
. Given that this app is to be used by hotel employees that have to accept the email addresses given by their guests, such as input validation is overly restrictive and compromises on its ability to be used in actual hotels.
[original: nus-cs2103-AY2324S1/pe-interim#3103] [original labels: type.FeatureFlaw severity.Medium]
[This is the team's response to the above 'original' bug]
Due to the nature of this project and to improve security, we have purposely restricted the valid domains.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
Reason for disagreement: [replace this with your explanation]
Only 5 domains are accepted when there are many other valid ones. 1 example is the school email which is ...@nus.edu.sg, and its not accepted