search

derekkraan / curl_req

req to curl and back
https://hex.pm/packages/curl_req
MIT License
38 stars 2 forks source link

parse authorization header into auth steps #10

Closed kevinschweikert closed 1 week ago

kevinschweikert commented 1 week ago

This would (for now only) parse the Bearer token in the authorization header into the Req.Steps.auth mechanic. But honestly, the more i think about it, the more i think, this isn't necessary, because it's already a header and all the Req.Step does is put it in the header again. But i wanted to see, how you think about it. Feel free to close the PR if this is not needed.

derekkraan commented 1 week ago

I think it makes sense to stick close to the canonical way of doing things, and Req does encourage using the provided steps to build your requests.

So I am in favour of this PR.