search

derekkraan / curl_req

req to curl and back
https://hex.pm/packages/curl_req
MIT License
38 stars 2 forks source link

Native curl mode #12

Closed kevinschweikert closed 3 days ago

kevinschweikert commented 1 week ago

Closes #7

This will now use the native curl compression option and native curl user agent for the command generation, as discussed in the linked issue. Hope you agree with my naming choices, but feel free to make changes! I've also upgraded Req to the latest version.

derekkraan commented 1 week ago

This is looking great!

I am still kind of torn on mode vs style. Can you tell me why you like mode better?

kevinschweikert commented 1 week ago

My though was that style could be confused with the flags (style). But I agree, mode doesn't fit perfectly either. What about flavour?

derekkraan commented 1 week ago

I do like flavour. Let's let it marinade for a day or two.

derekkraan commented 5 days ago

Let's do flavour, but also support flavor, the American English spelling.

What do you think?

kevinschweikert commented 4 days ago

I like it! I will implement the changes soon!

kevinschweikert commented 3 days ago

I've updated the PR with the changes to flavor/flavor and i snuck in a small change to support the --compressed flag also in the parser

derekkraan commented 3 days ago

Looks great, thanks for this :)