search

derekkraan / delta_crdt_ex

Use DeltaCrdt to build distributed applications in Elixir
MIT License
493 stars 36 forks source link

notify option is not supported yet #50

Closed hissssst closed 4 years ago

hissssst commented 4 years ago

I can provide the PR

zachdaniel commented 4 years ago

This would be great to see :)

derekkraan commented 4 years ago

Hi, can you explain what the notify option would do?

zachdaniel commented 4 years ago

The option is documented here: https://hexdocs.pm/delta_crdt/DeltaCrdt.html#start_link/2

But isn't supported.

derekkraan commented 4 years ago

Ah yes, this option was supported in the past but was removed in favour of on_diffs, which you can see documented here: https://hexdocs.pm/delta_crdt/DeltaCrdt.html#t:crdt_option/0

You can make on_diffs do the same job as a notify would have done.

I would accept a PR to clean up the documentation.