search

derekkraan / horde

Horde is a distributed Supervisor and Registry backed by DeltaCrdt
MIT License
1.32k stars 106 forks source link

Ensure Registry.child_spec/1 overridable. #143

Closed Ajwah closed 5 years ago

Ajwah commented 5 years ago
Ajwah commented 5 years ago

sure I will do in separate PR

On Thu., Jul. 25, 2019, 4:36 a.m. Derek Kraan, notifications@github.com wrote:

@derekkraan commented on this pull request.

In lib/horde/registry.ex https://github.com/derekkraan/horde/pull/143#discussion_r307177564:

@callback init(options :: Keyword.t()) :: {:ok, options :: Keyword.t()}

  • @callback child_spec(options :: [option()]) :: Supervisor.child_spec()

Also, could you please add this to Horde.Supervisor?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/derekkraan/horde/pull/143?email_source=notifications&email_token=AC2MTNDFXKYH6JMKJUDW64LQBFQZ5A5CNFSM4IGWX3X2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7RB3BI#discussion_r307177564, or mute the thread https://github.com/notifications/unsubscribe-auth/AC2MTNDRVJTJJNELFEEGDPDQBFQZ5ANCNFSM4IGWX3XQ .