search

dereklee0310 / RussianFishing4Script

Russian Fishing 4 Bot
GNU General Public License v3.0
67 stars 20 forks source link

[FEATURE] Keep Unmarked Bait Fish #18

Closed tnpe closed 5 months ago

tnpe commented 5 months ago

The current version supports keeping all fishes using "-a" flag or keeping marked fishes only using the "-m" flag.

In addition to these two options, I am wondering if the feature of keeping some bait fish, e.g., saithe, even if they are unmarked while keeping marked fish only for those cannot be used to make biat could be added in a later version. Thanks!

dereklee0310 commented 5 months ago

Seems like a good idea. It would be better if you could provide a list of fish types that should bypass the mark checking mechanism, e.g. saithe, mackerel, etc. In this case the user can whitelist the fish they want to keep to override the rule.

tnpe commented 5 months ago

Thanks, Derek. For saltwater fishing, I think unmarked Saithe and Mackerel are the most commonly used bait fish. Unmarked Atlantic Herring is less commonly used. I am not quite familiar with bait fish species in freshwater fishing though.

dereklee0310 commented 5 months ago

Whitelist for release of unmarked fish has been added, supporting mackerel, saithe, herring, squid, scallop, and mussel.