Typo on routes, method names and jobs. - Githubissues

derekmorash / rails-5-shopify-app

A base shopify app built on Ruby on Rails

3 stars 3 forks source link

Typo on routes, method names and jobs. #2

Open NajmaMalik opened 2 years ago

NajmaMalik commented 2 years ago

https://github.com/derekmorash/rails-5-shopify-app/blob/1c43b9d770ba099298e736afa73b2ef60329b8a8/shopify_base_app/app/controllers/mandatory_webhooks_controller.rb#L10 https://github.com/derekmorash/rails-5-shopify-app/blob/1c43b9d770ba099298e736afa73b2ef60329b8a8/shopify_base_app/app/controllers/mandatory_webhooks_controller.rb#L16

methods names not matched according to routes specified here: https://github.com/derekmorash/rails-5-shopify-app/blob/1c43b9d770ba099298e736afa73b2ef60329b8a8/shopify_base_app/config/routes.rb#L11-L12

It is just a typo, I think.

Similar typo here, https://github.com/derekmorash/rails-5-shopify-app/blob/1c43b9d770ba099298e736afa73b2ef60329b8a8/shopify_base_app/app/controllers/mandatory_webhooks_controller.rb#L12 and https://github.com/derekmorash/rails-5-shopify-app/blob/1c43b9d770ba099298e736afa73b2ef60329b8a8/shopify_base_app/app/controllers/mandatory_webhooks_controller.rb#L18

It should be according to job class names: https://github.com/derekmorash/rails-5-shopify-app/blob/1c43b9d770ba099298e736afa73b2ef60329b8a8/shopify_base_app/app/jobs/customers_redact_job.rb#L1 https://github.com/derekmorash/rails-5-shopify-app/blob/1c43b9d770ba099298e736afa73b2ef60329b8a8/shopify_base_app/app/jobs/customers_data_request_job.rb#L1