search

derekmorash / rails-5-shopify-app

A base shopify app built on Ruby on Rails
3 stars 3 forks source link

Response status should be 200 #3

Open NajmaMalik opened 2 years ago

NajmaMalik commented 2 years ago

https://github.com/derekmorash/rails-5-shopify-app/blob/1c43b9d770ba099298e736afa73b2ef60329b8a8/shopify_base_app/app/controllers/mandatory_webhooks_controller.rb#L7

https://github.com/derekmorash/rails-5-shopify-app/blob/1c43b9d770ba099298e736afa73b2ef60329b8a8/shopify_base_app/app/controllers/mandatory_webhooks_controller.rb#L13

https://github.com/derekmorash/rails-5-shopify-app/blob/1c43b9d770ba099298e736afa73b2ef60329b8a8/shopify_base_app/app/controllers/mandatory_webhooks_controller.rb#L19

Here all this responding with status 204 instead of 200 according to here https://shopify.dev/apps/webhooks/configuration/mandatory-webhooks#respond-to-mandatory-webhooks

So, it needs to be head :ok