search

derekriemer / nvda-notepadPlusPlus

GNU General Public License v2.0
28 stars 20 forks source link

Upgrade markdown to 2.6.11 #14

Closed tspivey closed 6 years ago

tspivey commented 6 years ago

This PR upgrades markdown to 2.6.11. markdown now depends on importlib, and uses absolute imports so I had to move htmlentitydefs up a level.

The imp hack is to get markdown to successfully load its extensions. If I don't do it this way, markdown ends up at appModules.notepad++.markdown. Is there a better way I can do this?

derekriemer commented 6 years ago

Probably not. Does future import absolute_imports break things? I'm half tempted to ask the original author to put this in his own addon and remove this dep and the assosiated feature since it's better for a global plugin.

tuukkao commented 6 years ago

Personally I would rather see this feature in a global plugin. IN fact I think that's what I suggested when this pr first came up but it might have been on some other forum. Anyway, I don't see a reason for not taking this in; it will benefit a separate plugin just as well.

derekriemer commented 6 years ago

we'll take this in for the value of the code hack for other potential future addons, however it's likely if markdown is ever split out into a plugin by Robbert, I'll remove the code.