support nvm installed by homebrew on Mac

derekstavis / plugin-nvm

Node version manager wrapper for Fish shell

MIT License

233 stars 12 forks source link

support nvm installed by homebrew on Mac #5

Closed 3cp closed 8 years ago

derekstavis commented 8 years ago

Hey @huochunpeng, thanks a lot for the PR. Although I'm not using nvm through brew this is very welcome to the plugin. I've done some considerations on the PR which I would like to address before merging it.

3cp commented 8 years ago

Ideally, it's better to test .install-linux.sh on osx too. But I don't know how to create 2 variants on osx while keep 1 variant on linux in .travis.yml.

derekstavis commented 8 years ago

Would you mind squashing fixup commits? I m willing to merge this so I can work on improving testing and load speed on OS X.

3cp commented 8 years ago

done.