Wip/gtk 3.12

[evfool]

Appmenu changes:

• Renamed Contents to Help
• Moved Quit into the same section as Help and About

Statusbar changes:

• Moved upload and download speed labels from status bar to headerbar subtitle
• Removed Statistics label and button from the statusbar

Torrent rendering changes:

• In full mode increase the icon padding to better match the design

[derekstavis]

Hey @evfool your branch compiled smooth here. The only problem is that I can't see the changes described in the PR. This is what I get when running from your branch:

[derekstavis]

I will cherry-pick 952a8a7, be52404 and 9c64598 commits into a branch dedicated to Milestone 1 (check wiki, please). From this branch I will create another one for development, so I can merge ideas and other design changes. I recommend you to read Wiki to understand why this will be done.

[evfool]

The icon padding change is there, the statusbar changes are there too (download speed and upload speed labels moved to subtitle, but not displaying as you are not uploading/downloading, statistics label and button removed), and the menu changes can be seen too: Contents renamed to Help, Quit moved to the same section as About and Help. The initial version of the merge request included removal of Start all and Pause all, but they have been readded based on the request of @me4oslav from #3. Which change are you missing from the PR's description?

[me4oslav]

I can not compile it: tr-prefs.c:899:13: error: too few arguments to function ‘gtk_button_new_from_icon_name’ w = gtk_button_new_from_icon_name ("list-remove-symbolic"); ^ In file included from /usr/include/gtk-3.0/gtk/gtk.h:54:0, from tr-prefs.c:17: /usr/include/gtk-3.0/gtk/gtkbutton.h:100:16: note: declared here GtkWidget* gtk_button_new_from_icon_name (const gchar _icon_name, ^ tr-prefs.c:905:9: warning: implicit declaration of function ‘gtk_button_new_from_image_name’ [-Wimplicit-function-declaration] w = gtk_button_new_from_image_name ("list-add-symbolic"); ^ tr-prefs.c:905:9: warning: nested extern declaration of ‘gtk_button_new_from_image_name’ [-Wnested-externs] tr-prefs.c:905:11: warning: assignment makes pointer from integer without a cast w = gtk_button_new_from_image_name ("list-add-symbolic"); ^ tr-prefs.c:910:9: warning: ‘gtk_alignment_new’ is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtkalignment.h:79) [-Wdeprecated-declarations] gtk_box_pack_start (GTK_BOX (w), gtk_alignment_new (0, 0, 0, 0), ^ tr-prefs.c: In function ‘speedPage’: tr-prefs.c:1064:5: warning: ‘gtk_misc_set_alignment’ is deprecated (declared at/usr/include/gtk-3.0/gtk/deprecated/gtkmisc.h:72) [-Wdeprecated-declarations] gtk_misc_set_alignment (GTK_MISC (w), 0.0f, 0.5f); ^ tr-prefs.c:1064:5: warning: ‘gtk_misc_get_type’ is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtkmisc.h:70) [-Wdeprecated-declarations] tr-prefs.c:1075:9: warning: ‘gtk_misc_set_alignment’ is deprecated (declared at/usr/include/gtk-3.0/gtk/deprecated/gtkmisc.h:72) [-Wdeprecated-declarations] gtk_misc_set_alignment (GTK_MISC (w), 0.0f, 0.5f); ^ tr-prefs.c:1075:9: warning: ‘gtk_misc_get_type’ is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtkmisc.h:70) [-Wdeprecated-declarations] tr-prefs.c: In function ‘networkPage’: tr-prefs.c:1203:3: warning: ‘gtk_misc_set_alignment’ is deprecated (declared at/usr/include/gtk-3.0/gtk/deprecated/gtkmisc.h:72) [-Wdeprecated-declarations] gtk_misc_set_alignment (GTK_MISC (l), 0.0f, 0.5f); ^ tr-prefs.c:1203:3: warning: ‘gtk_misc_gettype’ is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtkmisc.h:70) [-Wdeprecated-declarations] Makefile:677: recipe for target 'tr-prefs.o' failed make[3]: ** [tr-prefs.o] Error 1 make[3]: Leaving directory '/home/me4oslav/Downloads/transmission-master/gtk' Makefile:795: recipe for target 'all-recursive' failed make[2]: * [all-recursive] Error 1 make[2]: Leaving directory '/home/me4oslav/Downloads/transmission-master/gtk' Makefile:558: recipe for target 'all' failed make[1]: * [all] Error 2 make[1]: Leaving directory '/home/me4oslav/Downloads/transmission-master/gtk' Makefile:479: recipe for target 'all-recursive' failed make: *\ [all-recursive] Error 1

[me4oslav]

@derekstavis What exactly are we aiming for milestone 1? Redesign of appmenu, headerbar and nuking statusbar, because we will transfer her stuff in the headerbar? P.S. Well, sans the start/pause experience, because as far as I know for milestone one we're just making the headerbar button pause/start a single torrent and keeping the pause/start all in the appmenu.

[derekstavis]

@evfool Sorry, it's alright with the PR. It was a bit tired and misunderstood the PR description.

[derekstavis]

@me4oslav yeah. That's pretty what I planned. Button on Headerbar for start/pause selected torrent (detects state) when selected, stays insensitive when no selection, keep the start/stop all in app menu. Status bar is hard, because I don't want to miss a single feature, like the kind of statistics shown in status bar, the one click speed limit, etc. We don't want to be another gnome-terminal that removes features every new release :+1:

[me4oslav]

@derekstavis gnome-terminal is the worst, mostly because the design is woeful. In our design the turtle button hosts the speed limits and ability to change and activate them, the speed statstics are show is below the windows title in the headerbar. And ration is show below in the torrents panes themselves, so I guess we can safely nuke the statusbar.

[derekstavis]

@me4oslav Not all statistics are shown... Currently we have 4 options of statistics to be shown:

• Total Ratio
  • All ratio accumulated since the very first downloaded torrent that's on the list
• Session Ratio
  • All ratio accumulated since the program was open
• Total Transfer
  • All transfer accumulated since the very first downloaded torrent that's on the list
• Session Transfer
  • All transfer accumulated since the program was open

We need a way to accomodated this information.

Moving the statistics to subtitle looks very sweet, I agree, but where do we display the current filter? That's an important information to keep affix on program main window.

[derekstavis]

About speed limit there is probably a misunderstanding about the use case of the popover vs the turtle icon.

The popover changes global speed limits. It has been proposed as a feature copied from OS X Transmission client.

The turtle button signal/activate the alternative speed limit, as configured in the very first settings tab. This button is also very important to be visible on the UI, as when you configure a scheduled alternative speed limit it also serves as an indicator of "alternative speed limits enabled".