search

derekwyatt / vim-scala

My work on integration of Scala into Vim - not a ton here, but useful for me.
http://derekwyatt.org
Apache License 2.0
1.09k stars 144 forks source link

Multiline comment color does not persist on use of => in the comment #100

Closed aa8y closed 8 years ago

aa8y commented 9 years ago

When I use an arrow in the comment, its blue color does not persist.

comcolor

I don't know if it's a problem with my vim or a bug in the plugin.

derekwyatt commented 9 years ago

Nope, this is a bug with the plugin. We're including HTML in comments with the html syntax file, and a lone > is an error, which screws up everything that follows.

Does anyone else have any thoughts here? I'm happy to remove the HTML but I'm betting I'm in the minority.

slothspot commented 9 years ago

Hi. Faced this problem recently. For myself, I removed @scalaHtml from scalaMultilineComment. I would vote for removing of HTML from Scala highlight definition or make it optional. Another approach, as I understand, is to modify HTML highlight definition itself.

henrytill commented 8 years ago

:+1: for removing @scalaHtml from scalaMultilineComment

derekwyatt commented 8 years ago

@ches Whatdya think? I'm all for tossing it.

aa8y commented 8 years ago

Any updates on this?

ches commented 8 years ago

I'm not particularly attached to the HTML embedding. If someone feels strongly about wanting it back, perhaps they can try to figure a way to write the syntax definition that works around this issue.

derekwyatt commented 8 years ago 
                                                                                  I'm all for ripping it out.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                         From: Ches MartinSent: Monday, February 1, 2016 8:52 AMTo: derekwyatt/vim-scalaReply To: derekwyatt/vim-scalaCc: Derek WyattSubject: Re: [vim-scala] Multiline comment color does not persist on use of => in the comment (#100)I'm not particularly attached to the HTML embedding. If someone feels strongly about wanting it back, perhaps they can try to figure a way to write the syntax definition that works around this issue.

—Reply to this email directly or view it on GitHub.

henrytill commented 8 years ago

I opened a PR to remove it: #121