Use shiftwidth() instead of &shiftwidth

[tyru]

Recently, I sent a patch to vim_dev, you know, Vim developer mailing list. Remaining &shiftwidth references in indent plugins - Google Groups

shiftwidth(), introduced in Vim 7.4.694, should be used instead of direct reference to '&shiftwidth' option value. 'set sw=0' makes Vim behave like 'set sw={tabstop option value}' (:help shiftwidth()).

But currently this feature does not work on your indent plugins due to the direct reference '&shiftwidth'.

And I guess you are the maintainer of this indent plugin. If you include this pull request, would you like to send the latest indent plugin to Bram?

[derekwyatt]

The plugin is now part of the standard vim distribution. You should be making pull requests there instead.Thanks From: notifications@github.comSent: February 20, 2017 09:21To: vim-scala@noreply.github.comReply-to: reply@reply.github.comCc: subscribed@noreply.github.comSubject: [derekwyatt/vim-scala] Use shiftwidth() instead of &shiftwidth (#136) Recently, I sent a patch to vim_dev, you know, Vim developer mailing list. Remaining &shiftwidth references in indent plugins - Google Groups shiftwidth(), introduced in Vim 7.4.694, should be used instead of direct reference to '&shiftwidth' option value. 'set sw=0' makes Vim behave like 'set sw={tabstop option value}' (:help shiftwidth()). But currently this feature does not work on your indent plugins due to the direct reference '&shiftwidth'. And I guess you are the maintainer of this indent plugin. If you include this pull request, would you like to send the latest indent plugin to Bram?

You can view, comment on, or merge this pull request online at:   https://github.com/derekwyatt/vim-scala/pull/136

Commit Summary Use shiftwidth() instead of &shiftwidth

File Changes

M
indent/scala.vim
(30)

Patch Links: https://github.com/derekwyatt/vim-scala/pull/136.patchhttps://github.com/derekwyatt/vim-scala/pull/136.diff

—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.

[tyru]

@derekwyatt Okay. created https://github.com/vim/vim/issues/1493

[chrisbra]

Runtime file maintainers are expected to take care of changes, sending complete runtime files to Bram every once in a while for updating. We generally do not handle runtime file updates to prevent inconsistencies between the version included in Vim and the one from the maintainer.

[derekwyatt]

But my version is your version - i.e. I use what everyone else uses. How do other people do it? Do they run a perpetual fork of vim and then wait until they've accumulated a certain amount of change?  Sent via the BlackBerry Hub for Android From: notifications@github.comSent: February 20, 2017 10:12To: vim-scala@noreply.github.comReply-to: reply@reply.github.comCc: derek@derekwyatt.org; mention@noreply.github.comSubject: Re: [derekwyatt/vim-scala] Use shiftwidth() instead of &shiftwidth (#136) Runtime file maintainers are expected to take care of changes, sending complete runtime files to Bram every once in a while for updating. We generally do not handle runtime file updates to prevent inconsistencies between the version included in Vim and the one from the maintainer.

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

[chrisbra]

I cannot talk for others, but here is what I do. Sooner or later you might discover a bug in your plugin that you want to fix (or add an enhancement) or whatever. You clone your (upstream) repository into your ~/.vim folder, which usually comes before the system wide $VIMRUNTIME (/usr/share/vim/vim80) folder, so your plugin would be used instead of the one provided with Vim. You would then change your runtime file and add it to your repository and test it for a while. Once you are satisfied, you send the complete file to Bram for inclusion.

[derekwyatt]

Alright. Thanks. I'll set up my fork such that people can submit things there. Once I've accumulated enough fixes or enough time has passed, I'll ship it off to Bram.  Sent via the BlackBerry Hub for Android From: notifications@github.comSent: February 20, 2017 16:09To: vim-scala@noreply.github.comReply-to: reply@reply.github.comCc: derek@derekwyatt.org; mention@noreply.github.comSubject: Re: [derekwyatt/vim-scala] Use shiftwidth() instead of &shiftwidth (#136) I cannot talk for others, but here is what I do. Sooner or later you might discover a bug in your plugin that you want to fix (or add an enhancement) or whatever. You clone your (upstream) repository into your ~/.vim folder, which usually comes before the system wide $VIMRUNTIME (/usr/share/vim/vim80) folder, so your plugin would be used instead of the one provided with Vim. You would then change your runtime file and add it to your repository and test it for a while. Once you are satisfied, you send the complete file to Bram for inclusion.

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

[tyru]

@derekwyatt @chrisbra Should I re-open this pull request?

[derekwyatt]

Sure. It might not be what I do in the end but let's try this as a process for the time being. The fix won't be done on this particular repository though.

On Sat, Feb 25, 2017, 6:12 AM Takuya Fujiwara notifications@github.com wrote:

@derekwyatt https://github.com/derekwyatt @chrisbra https://github.com/chrisbra Should I re-open this issue?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/derekwyatt/vim-scala/pull/136#issuecomment-282477328, or mute the thread https://github.com/notifications/unsubscribe-auth/AADzdDnVeNEdTinqk_AHjBZ-waAHGH2Yks5rgAy4gaJpZM4MGPAS .

[derekwyatt]

Added to vim as https://github.com/vim/vim/pull/1553

[tyru]

Thanks!

[ches]

Applied this here in c4a1fa43069d2fb80621e87cb12623d2e907ab60, as per https://github.com/derekwyatt/vim-scala/pull/137#issuecomment-896957164 and discussion above—regarding us in this repo as upstream and Vim as downstream.