search

derekwyatt / vim-scala

My work on integration of Scala into Vim - not a ton here, but useful for me.
http://derekwyatt.org
Apache License 2.0
1.09k stars 144 forks source link

Clear highlights instead of link to Normal #159

Closed GordianDziwis closed 3 years ago

GordianDziwis commented 4 years ago

Linking to the normal highlight group sets the background, this gives the wrong highlight in floating windows. See https://github.com/neoclide/coc.nvim/issues/1512

jsatk commented 3 years ago

@derekwyatt can we get this merged?

derekwyatt commented 3 years ago

Unfortunately I don't code in Scala anymore. I'd like to pass this by others that do... @ches for example? Any thoughts?

ches commented 3 years ago

I don't have a plugin setup currently where I can readily render Scala syntax in the Pmenu to reproduce & confirm, but I can say I've tried applying the patch and I don't see adverse effects, with the concerned highlight groups or otherwise.

ches commented 3 years ago

(Also I just chortled at seeing type Booger[A] = A => Unit again in the testfile so that little laugh trap has found another quarry).

derekwyatt commented 3 years ago

LOL. Alright, if you're good with it, then I'm good with it. Thanks guys.