Showcase antipattern of chainable typehint

dereuromark / cakephp-file-storage

Abstract file storage and upload plugin for CakePHP. Write to local disk, FTP, S3, Dropbox and more through a single interface. It's not just yet another uploader but a complete storage solution.

MIT License

4 stars 2 forks source link

Showcase antipattern of chainable typehint #1

Closed dereuromark closed 2 years ago

dereuromark commented 3 years ago

Shows that one MUST NOT add param and return types for chainable

$this / static in docblock
NO types
tooling verification using CS (done with Spryker code sniffer)

then both phpstan and IDEs are happy, and there is still literally 0 change of failure, as well as even faster more performant code around this.