search

dereuromark / cakephp-hashid

CakePHP plugin to use hashids for your database table lookups
MIT License
36 stars 13 forks source link

Use latest hashids release #21

Closed davidyell closed 5 years ago

davidyell commented 5 years ago

Resolves #20

The aim of this pull request is to upgrade the plugin to using the latest version of the hashids/hashids library.

The latest release has a higher PHP requirement too, so this is also reflected in this pull request.

The current test suite passes with the new version without issues on PHP Unit 6.5.13

codecov-io commented 5 years ago

Codecov Report

Merging #21 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #21   +/-   ##
=========================================
  Coverage     90.75%   90.75%           
  Complexity       64       64           
=========================================
  Files             3        3           
  Lines           119      119           
=========================================
  Hits            108      108           
  Misses           11       11

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fd63f53...1a218c0. Read the comment docs.

dereuromark commented 5 years ago

You could check if ^1.0|^2.0|^3.0 can work already with some internal shimming. Travis matrix will automatically test all versions anyway then.