search

dereuromark / cakephp-ide-helper

IDE Helper plugin for CakePHP
MIT License
185 stars 39 forks source link

First stab at new fetchTable() #320

Closed dereuromark closed 1 year ago

dereuromark commented 1 year ago

First stab at https://github.com/dereuromark/cakephp-ide-helper/issues/317 @LordSimal

We might have to backport some if it as well

And it will also wrongly add the docblocks in case you did set a property allready in an extending class (e.g. parent controller or command). So we might have to exclude any that already exist as property (e.g. via reflection)? Could be a follow up PR

codecov-commenter commented 1 year ago

Codecov Report

Merging #320 (28fcf3f) into cake5 (bb3aafd) will increase coverage by 0.02%. The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##              cake5     #320      +/-   ##
============================================
+ Coverage     81.08%   81.10%   +0.02%     
  Complexity     1783     1783              
============================================
  Files           115      116       +1     
  Lines          4864     4865       +1     
============================================
+ Hits           3944     3946       +2     
+ Misses          920      919       -1
Impacted Files Coverage Δ
src/Annotator/CommandAnnotator.php 84.21% <ø> (+0.21%) :arrow_up:
src/Annotator/ControllerAnnotator.php 80.59% <ø> (-0.84%) :arrow_down:
src/Annotator/Traits/ModelTrait.php 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

LordSimal commented 1 year ago

Right, just calling fetchTable() without doing anything with the result shouldn't result in an annotation LGTM 👍🏻