search

dereuromark / cakephp-ide-helper

IDE Helper plugin for CakePHP
MIT License
186 stars 39 forks source link

Cake5: fix IlluminateCommand #321

Closed LordSimal closed 1 year ago

LordSimal commented 1 year ago

Previously it seems that the Shell had access to the options/arguments before they were built.

But now io and $args are only available in the execute method so there is no real way to pass down the arguments to the TaskCollection while they are built.

codecov-commenter commented 1 year ago

Codecov Report

Merging #321 (d754644) into cake5 (9a81522) will increase coverage by 1.13%. The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##              cake5     #321      +/-   ##
============================================
+ Coverage     81.10%   82.24%   +1.13%     
  Complexity     1783     1783              
============================================
  Files           116      116              
  Lines          4865     4867       +2     
============================================
+ Hits           3946     4003      +57     
+ Misses          919      864      -55
Impacted Files Coverage Δ
src/Command/IlluminateCommand.php 88.88% <100.00%> (+88.88%) :arrow_up:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more