dereuromark / cakephp-ide-helper

IDE Helper plugin for CakePHP
MIT License
186 stars 39 forks source link

Allow more complex array parsing #357

Closed dereuromark closed 1 month ago

dereuromark commented 1 month ago

Resolves https://github.com/dereuromark/cakephp-ide-helper/issues/354

Could replace https://github.com/dereuromark/cakephp-ide-helper/pull/356

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.50%. Comparing base (446a2f4) to head (746140d). Report is 1 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #357 +/- ## ============================================ + Coverage 83.34% 83.50% +0.15% + Complexity 1801 1799 -2 ============================================ Files 114 114 Lines 4906 4923 +17 ============================================ + Hits 4089 4111 +22 + Misses 817 812 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Harfusha commented 1 month ago

Complex types are working in annotator, but not in illuminator.

@property array{utm_tags: array<mixed>|null}|null $data ! This still produce this: public const FIELD_TA = 'ta';

Same for this: @property array{user?: int, account?: int|string, newContacts?: array<mixed>}|null $data ! public const FIELD_ATA = 'ata';

Harfusha commented 1 month ago

Still same problem here: @property array{utm_tags: array<mixed>|null}|null $data ! public const FIELD_ATA = 'ata';

Harfusha commented 1 month ago

Now the problem is again the first one

@property array{user?: int, account?: int|string, newContacts?: array<mixed>}|null $data ! public const FIELD_ATA = 'ata';

dereuromark commented 1 month ago

The tests look correct, no?