dereuromark / cakephp-queue

Queue plugin for CakePHP - simple, pure PHP and without dependencies.
MIT License
306 stars 137 forks source link

Deprecation message in PHP 8.1 #340

Closed mrothauer closed 2 years ago

mrothauer commented 2 years ago

in version 6.4.2

deprecated: 16384 :: allowEmpty() is deprecated. Use allowEmptyString(), allowEmptyArray(), allowEmptyFile(), allowEmptyDate(), allowEmptyTime(), allowEmptyDateTime() or allowEmptyFor() instead.
D:\htdocs\foodcoopshop.dev\vendor\dereuromark\cakephp-queue\src\Model\Table\QueuedJobsTable.php, line: 178

The field progress has float as type, I don't know if allowEmptyString is the correct validation method.

dereuromark commented 2 years ago

:/ I hate those new methods I wonder what the best way forward would be. For now I would recommend silencing vendor and specifically that plugin for the deprecations as documented.

mrothauer commented 2 years ago

ok thanks for your quick reply https://github.com/foodcoopshop/foodcoopshop/commit/124cc0746237483fa4b11eb153b6dff6cfb8da5b

dereuromark commented 2 years ago

https://github.com/dereuromark/cakephp-queue/releases/tag/6.4.3