search

dereuromark / cakephp-sandbox

A CakePHP Sandbox app to test and showcase misc. features and tools.
https://sandbox.dereuromark.de
MIT License
60 stars 37 forks source link

Fix up tests for binary16. #67

Closed dereuromark closed 1 year ago

dereuromark commented 1 year ago

Lets see if this fixes the broken binary16 support

Refs https://github.com/cakephp/cakephp/pull/17421 and https://github.com/cakephp/phinx/pull/2239

codecov-commenter commented 1 year ago

Codecov Report

Attention: 130 lines in your changes are missing coverage. Please review.

Comparison is base (a5fc5e0) 9.32% compared to head (6d5b75e) 9.26%. Report is 57 commits behind head on master.

:exclamation: Current head 6d5b75e differs from pull request most recent head b34aa93. Consider uploading reports for the commit b34aa93 to get more accurate results

Files Patch % Lines
.../Sandbox/src/Controller/CakeExamplesController.php 0.00% 18 Missing :warning:
src/Controller/ExportController.php 25.00% 15 Missing :warning:
plugins/Sandbox/src/Controller/CsvController.php 0.00% 14 Missing :warning:
...ndbox/src/Controller/DecimalExamplesController.php 0.00% 13 Missing :warning:
...andbox/src/Controller/SearchExamplesController.php 0.00% 10 Missing :warning:
.../Sandbox/src/Controller/AjaxExamplesController.php 0.00% 9 Missing :warning:
...andbox/src/Controller/JqueryExamplesController.php 0.00% 7 Missing :warning:
...ns/Sandbox/src/Controller/SandboxAppController.php 0.00% 5 Missing :warning:
src/Controller/AccountController.php 0.00% 5 Missing :warning:
...Sandbox/src/Controller/CacheExamplesController.php 0.00% 4 Missing :warning:
... and 14 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #67 +/- ## =========================================== - Coverage 9.32% 9.26% -0.06% - Complexity 671 675 +4 =========================================== Files 84 82 -2 Lines 2456 2450 -6 =========================================== - Hits 229 227 -2 + Misses 2227 2223 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dereuromark commented 1 year ago

Finally green again :tada: