dereuromark / cakephp-tags

CakePHP Tags Plugin
MIT License
14 stars 10 forks source link

Copyright info / attribution to muffin/tags missing. #3

Closed ADmad closed 6 years ago

ADmad commented 6 years ago

Since this plugin is based off muffin/tags and still contains a lot of the original code it would be prudent to keep the copyright of original plugin or at least add an attribution link in your readme/license file.

dereuromark commented 6 years ago

It does. also see composer.json. The license Block was invalid (missing mit license Header MIT) by the way.

dereuromark commented 6 years ago

Personally I find the composer and thus packagist linking more relevant and visible. https://packagist.org/packages/dereuromark/cakephp-tags But it probably wouldnt hurt to readd the name in license file instead of completely replacing.

dereuromark commented 6 years ago

Resolved with https://github.com/dereuromark/cakephp-tags/commit/f170c8725c0848820f4ca87a393717e925779966 ?

ADmad commented 6 years ago

Thanks.