search

dereuromark / cakephp-tools

A CakePHP Tools plugin containing lots of useful helpers, behaviors, components, shells, ...
http://www.dereuromark.de
MIT License
336 stars 142 forks source link

Fix up internal 404s and consolidate via trait #196

Closed dereuromark closed 6 years ago

dereuromark commented 6 years ago

Those should not be moved into 404 log with the rest, since those are internally caused errors through faulty URLs on the page.

//cc @inoas

codecov-io commented 6 years ago

Codecov Report

Merging #196 into master will increase coverage by 0.25%. The diff coverage is 60.86%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #196      +/-   ##
============================================
+ Coverage      68.9%   69.16%   +0.25%     
- Complexity     1761     1766       +5     
============================================
  Files            50       51       +1     
  Lines          4117     4132      +15     
============================================
+ Hits           2837     2858      +21     
+ Misses         1280     1274       -6
Impacted Files Coverage Δ Complexity Δ
src/Error/ErrorHandler.php 0% <0%> (ø) 2 <0> (-2) :arrow_down:
src/Error/Middleware/ErrorHandlerMiddleware.php 25% <0%> (+25%) 3 <0> (-2) :arrow_down:
src/Error/ErrorHandlerTrait.php 66.66% <66.66%> (ø) 9 <9> (?)
src/TestSuite/ToolsTestTrait.php 70.37% <0%> (+18.51%) 12% <0%> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d6f2570...b7b5c0d. Read the comment docs.