WIP: Fixing Deprecation Warnings

dereuromark / cakephp-tools

A CakePHP Tools plugin containing lots of useful helpers, behaviors, components, shells, ...

http://www.dereuromark.de

MIT License

336 stars 142 forks source link

WIP: Fixing Deprecation Warnings #214

Closed challgren closed 5 years ago

challgren commented 5 years ago

There's a couple deprecations in the CommonComponent that was also discussed in #206 its been a few months and no PR has been submitted. So here is the PR that brings the CommonComponent::startup(Event $event) to CakePHP 3.6.

I don't think any tests will need to be adjusted

challgren commented 5 years ago

Fixes #206

dereuromark commented 5 years ago

Looks like tests are failing. Using the new immutable ones can cause tricky side effects

I would like to hold off here for the time being Just dont use them if you disabled deprecation silencing.

challgren commented 5 years ago

I'm going to redo this PR