dereuromark / cakephp-tools

A CakePHP Tools plugin containing lots of useful helpers, behaviors, components, shells, ...
http://www.dereuromark.de
MIT License
336 stars 142 forks source link

Updating src files #220

Closed challgren closed 5 years ago

challgren commented 5 years ago

Supporting CakePHP 3.7.0

codecov-io commented 5 years ago

Codecov Report

Merging #220 into master will decrease coverage by 0.03%. The diff coverage is 55.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #220      +/-   ##
============================================
- Coverage     72.63%   72.59%   -0.04%     
- Complexity     1861     1862       +1     
============================================
  Files            56       56              
  Lines          4392     4394       +2     
============================================
  Hits           3190     3190              
- Misses         1202     1204       +2
Impacted Files Coverage Δ Complexity Δ
src/Controller/ShuntRequestController.php 0% <0%> (ø) 4 <0> (ø) :arrow_down:
src/Mailer/Email.php 62.76% <100%> (ø) 104 <0> (ø) :arrow_down:
src/Controller/Component/UrlComponent.php 100% <100%> (ø) 10 <0> (ø) :arrow_down:
src/Controller/Component/CommonComponent.php 72.11% <50%> (-1.42%) 58 <0> (ø)
src/Controller/Component/MobileComponent.php 87.69% <75%> (ø) 27 <0> (+1) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update acd91f3...2f76575. Read the comment docs.

dereuromark commented 5 years ago

Tests seem to fail.

challgren commented 5 years ago

Yeah I'm not sure how to fix the 1 error and the failure. Those are a little bit more advanced issues that I'm not sure how to resolve just yet.

dereuromark commented 5 years ago

Best to revert those then to avoid the PR to be blocked.

challgren commented 5 years ago

I'm 99% sure those failed before I modified a line of code. I'm running a travis build on my fork right now https://travis-ci.org/challgren/cakephp-tools/builds/474090734