Closed challgren closed 5 years ago
Merging #220 into master will decrease coverage by
0.03%
. The diff coverage is55.88%
.
@@ Coverage Diff @@
## master #220 +/- ##
============================================
- Coverage 72.63% 72.59% -0.04%
- Complexity 1861 1862 +1
============================================
Files 56 56
Lines 4392 4394 +2
============================================
Hits 3190 3190
- Misses 1202 1204 +2
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
src/Controller/ShuntRequestController.php | 0% <0%> (ø) |
4 <0> (ø) |
:arrow_down: |
src/Mailer/Email.php | 62.76% <100%> (ø) |
104 <0> (ø) |
:arrow_down: |
src/Controller/Component/UrlComponent.php | 100% <100%> (ø) |
10 <0> (ø) |
:arrow_down: |
src/Controller/Component/CommonComponent.php | 72.11% <50%> (-1.42%) |
58 <0> (ø) |
|
src/Controller/Component/MobileComponent.php | 87.69% <75%> (ø) |
27 <0> (+1) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update acd91f3...2f76575. Read the comment docs.
Tests seem to fail.
Yeah I'm not sure how to fix the 1 error and the failure. Those are a little bit more advanced issues that I'm not sure how to resolve just yet.
Best to revert those then to avoid the PR to be blocked.
I'm 99% sure those failed before I modified a line of code. I'm running a travis build on my fork right now https://travis-ci.org/challgren/cakephp-tools/builds/474090734
Supporting CakePHP 3.7.0