Thumbnail disappears from thumbnail list when closing a rendered image

[Dupond]

Hello,

I'll try to be as simple as possible : in thumbnail mode (feh -t), I navigate through my thumbnails, then render one (using the R keybind) and then close this image. Then when I go to the next or previous thumbnail in the thumbnails list, using the keybinds, the selected thumbnail appears transparent. If I go to the next one again, it's displayed correctly.

I've reproduced this with the default feh configuration, on several different computers ; so I've thought I'd submit it ;)

Best regards, Dupond

[ulteq]

Maybe I did something wrong, but I can't reproduce this with feh 2.26.

[Ferada]

No they're right, but it took me a moment to comprehend the description: Once you close the window and go back to the thumbnail view everything looks fine. Then, if you move with the cursor keys (doesn't happen with the mouse curiously enough) back or forth to one of the adjacent thumbnails, they'll be temporarily transparent, and will stay so as long as you don't move the current selection again.

Had to check, but this is with current master, but also unchanged from back in 2.20 apparently.

[derf]

Yup, I can confirm the issue as well.

[derf]

diff --git a/src/thumbnail.c b/src/thumbnail.c
index 003c7b4..4350f04 100644
--- a/src/thumbnail.c
+++ b/src/thumbnail.c
@@ -789,6 +789,7 @@ void feh_thumbnail_select(winwidget winwid, feh_thumbnail *thumbnail)
          return;

     if (thumbnail) {
+         winwidget_render_image(winwid, 0, 0);
          origwin = winwid->im;
          winwid->im = gib_imlib_clone_image(origwin);
          gib_imlib_image_fill_rectangle(winwid->im,

This is a workaround, now I just need to find the cause of the issue.

[ulteq]

Line 821 is what prevents this bug when the thumbnail is selected via the mouse cursor.

Your workaround would allow us to remove that line: https://github.com/derf/feh/blob/master/src/thumbnail.c#L821

and then close this image

Closing the image is not required to trigger this bug.