search

derf / travelynx

Traewelling-inspired journey logger with realtime data
https://travelynx.de
GNU Affero General Public License v3.0
102 stars 16 forks source link

FGR: account for cumulative delays ≥20 minutes #116

Open deingithub opened 4 months ago

deingithub commented 4 months ago

Because metronom's reliability is approaching an area where actually getting compensation for a 49 euro ticket starts becoming feasible month-for-month by me, i've decided to implement #73:

in the FGR page there's now an explanation and link to the new cumulative delays subpage: Screenshot 2024-02-09 at 19-56-47 travelynx

there's a progress bar on how much delays you have to "earn" to get at least some of your money back, and a list of offending trains with FGR form download links: Screenshot 2024-02-09 at 20-02-53 travelynx Zeitkarten-Fahrgastrechte Screenshot 2024-02-09 at 20-03-32 travelynx Zeitkarten-Fahrgastrechte

you can select which ticket (for which timeframe) you're using, which will change the projected reimbursement. selecting a regional ticket excludes long-distance trains. Screenshot from 2024-02-09 20-03-49

Screenshot 2024-02-09 at 20-07-01 travelynx Zeitkarten-Fahrgastrechte

this is my first contribution where i actually touched the perl code a bit. i do not know perl! the code might be awful and not idiomatic. i apologize in advance for that specifically.

have a nice weekend! :orange_heart:

deingithub commented 4 months ago

i noticed that it didn't actually account for train cancellations followed by a substitute connection yet, so i added that as well. it gets displayed like this: Screenshot 2024-02-14 at 19-17-45 travelynx Fahrgastrechte Zeitkarten

this PR doesn't touch the normal FGR view and all changes are exclusively in the cumulative view but i can convert the normal page to the departureboard style list too at a later point if so desired :)

deingithub commented 4 months ago

ok as what i hope is the final touch this time, the view now also includes missed connections like the regular FGR page: Screenshot from 2024-02-17 12-32-04

i've also added some visual restyling of the route history that hopefully better indicates that the direction of travel is "upwards": Screenshot 2024-02-17 at 14-03-28 travelynx Fahrgastrechte Zeitkarten Screenshot 2024-02-17 at 14-03-50 travelynx Fahrgastrechte Zeitkarten Screenshot 2024-02-17 at 14-03-12 travelynx Fahrgastrechte Zeitkarten

i applied the same formatting to the /cancelled page, which now looked a bit weird because the list of cancelled trains had the "success" checkmark at the top.

deingithub commented 2 months ago

Hey, I hope this doesn't come across as pushy, but I wanted to know if there's some timeframe for a review on this and the two smaller PRs — you mentioned #122 is on hold for now, that's totally fair of course. There's more stuff I'd like to start working on, buuut I also don't want to make the pile of PRs to review even bigger. I understand that there's probably a lot on your plate in general currently, just a "haven't forgotten about this" or some pointers where I could help with making review easier would be nice already :sweat_smile: Thanks!

derf commented 2 months ago

I have seen the PR, appreciate it, and will not provide a time frame. It's fairly certain that I'll review and merge it eventually.

travelynx is a hobby project which I work on whenever and wherever I feel like, and I find it healthy to take that hobby aspect seriously. Sorry about that ;)

deingithub commented 2 months ago

Not setting a timeframe is fully okay of course. Appreciate hearing back from you anyway, thanks!