Some pages don't display the version string correctly in the page footer. For example, /login on travelynx.de currently shows "travelynx v???" in the page footer:
This PR sets a default value for the version field of the request stash, so that this parameter is automatically set when rendering pages. As this parameter no longer needs to be passed explicitly, this PR also removes all occurrences of the explicit version parameter in existing page handlers.
Some pages don't display the version string correctly in the page footer. For example,
/login
on travelynx.de currently shows "travelynx v???" in the page footer:The template for the login page includes the
_footer
template fragment, and explicitly passes through theversion
parameter from the request stash: https://github.com/derf/travelynx/blob/0516344ac09214ca8dde0fe0d9fa7b7832213ef0/templates/login.html.ep#L101However, when this template is rendered in this request handler, the
version
parameter is never explicitly provided: https://github.com/derf/travelynx/blob/0516344ac09214ca8dde0fe0d9fa7b7832213ef0/lib/Travelynx/Controller/Account.pm#L235-L238As there is no default value set in the request stash, this results in the placeholder text "???" being used instead: https://github.com/derf/travelynx/blob/0516344ac09214ca8dde0fe0d9fa7b7832213ef0/templates/_footer.html.ep#L3
This PR sets a default value for the
version
field of the request stash, so that this parameter is automatically set when rendering pages. As this parameter no longer needs to be passed explicitly, this PR also removes all occurrences of the explicitversion
parameter in existing page handlers.