search

derhansen / sf_banners

Banner-Management is a banner management extension for TYPO3. It is based of Extbase and Fluid. Banners are loaded asynchronously using JavaScript so the page load time is affected as less as possible.
GNU General Public License v2.0
10 stars 20 forks source link

Compatibility with v8 ? #160

Closed adrienjacob closed 7 years ago

adrienjacob commented 7 years ago

Hi,

Are there any plans to make sf_banners compatible with the upcoming Typo3 v8 ? I just tried and it doesn't seem to work...

Thanks !

derhansen commented 7 years ago

Hi,

yes, I started yesterday with compatibility of my TYPO3 extensions for V8 and released a V8 compatible version of sf_yubikey.

Next up is sf_banners, so you may expect the update before the release of TYPO3 8.7 LTS.

Regards, Torben

adrienjacob commented 7 years ago

Great Torben, thanks a lot !

derhansen commented 7 years ago

Started working on the V8 version in this branch- https://github.com/derhansen/sf_banners/tree/v8_compatibility

adrienjacob commented 7 years ago

Thanks, I just tested it. After clearing the cache and running the DB analyser, it looks ok in the Frontend. However, in the Backend, when I try to update / create banners for language "All", I get this error Argument 3 passed to TYPO3\CMS\Core\DataHandling\Localization\DataMapProcessor::synchronizeTranslationItem() must be of the type integer, null given In TYPO3\CMS\Core\DataHandling\Localization\DataMapProcessor::synchronizeTranslationItem(TYPO3\CMS\Core\DataHandling\Localization\DataMapItem, array, NULL) It doesn't happen if I choose a particular language.

derhansen commented 7 years ago

I forgot to push the latest changes in the V8 Branch to GitHub. Now they are pushed and I also migrated the TCA

adrienjacob commented 7 years ago

Thanks @derhansen, works like a charm after pulling your latest changes, and also pulling the latest changes on the core (I'm using 8.7.0-dev).

derhansen commented 7 years ago

Thanks for your feedback. I will publish the new version to TER soon