search

derhansen / sf_banners

Banner-Management is a banner management extension for TYPO3. It is based of Extbase and Fluid. Banners are loaded asynchronously using JavaScript so the page load time is affected as less as possible.
GNU General Public License v2.0
10 stars 20 forks source link

[!!!][FEATURE] Fetch banners in one request #226

Closed derhansen closed 3 years ago

derhansen commented 3 years ago

Due to deadlock problems with multiple banner plugins on one page and also problems with Safari (see #223) banners should only be fetched using one single request.

swisschocolate-zz commented 3 years ago

Another approach: see Pull request #228 . This would also solve #223 .

derhansen commented 3 years ago

@swisschocolate I refactored the extension to use one single request to fetch all banners (see d5c8a3d). This should work fine in all browsers now and should also increase the overall performance of the extension a little bit.

Thanks a lot for your PR, which I really appreciate, but which I can not merge since the feature from this ticket is implemented now. I leave your PR open, since it may be a solution for users of the TYPO3 9/10 version of the extension, as only JS/HTML files are changed.