Package doesn't include all stations...

lemnis commented 2 years ago

It's a great package, countries "far" away from Germany are missing, but they do exist in hafas. E.g.

Malaga (Spain) ajax-getstop.exe timetable
Attymon (Ireland) ajax-getstop.exe timetable
Athens timetable etc...

Is there an easy fix to include those far away stations?

derhuerst commented 2 years ago

Thanks for reporting!

db-hafas-stations builds the list of stations by doing a graph walk, slowly discovering more stations by querying intermediate & destination stations of vehicles departing at the current station.

Three possible solutions to get Malaga & Co. included, with increasing levels of effort and benefit:

You could modify the build script to start walking the graph with a different station (e.g. Malaga), run the build script and abort it as soon as it has made its way through Spain, and then concatenate the discovered stations with the ones from the db-hafas-stations npm package. This has the disadvantage that it doesn't fix the problem permanently, repeatably.
Medium-term, it would be very worthwhile to extend hafas-discover-stations to start with multiple stations: Frankfurt Hbf, Malaga, Attymon, etc. I would be happy to review a PR for this!
Long-term, it should be interesting to find out why it didn't "reach" Malaga, starting from Berlin with filter criteria (next Monday 10:00 am, departures within 60min. We could try increasing the time span to e.g. 3 hours, or picking another time frame, e.g. on the weekend. Again, PR welcome!

traines-source commented 5 days ago

I have obtained a station list with ~27k additional stations, both inside and outside Germany (Malaga is in there, too ;): https://mirror.traines.eu/hafas-ibnr-zhv-gtfs-osm-matching/hafas-stations.ndjson

Some notes:

it's based on HAFAS traffic from the past year, i.e. no systematic collection and no guarantee for completeness (and, on the other hand, some stations may have ceased to exist)
merged with the existing list
weight set to 1 for all added stations, distance undefined
additionally corrects wrong geopositions of some train stations (list of wrong stations)
additionally contains field ifoptId for German train stations
can be used as a drop-in replacement for full.ndjson

IFOPT-IDs and corrected geopositions are based on D_Bahnhof_2020_alle.CSV, DB InfraGO, CC-BY-4.0.

derhuerst commented 5 days ago

@PaulSut wants to work on publishing a new version of db-hafas-stations! 🎉

derhuerst / db-hafas-stations

Package doesn't include all stations... #2