derhuerst / db-stations

A list of Deutsche Bahn stations.
ISC License
25 stars 4 forks source link

Hamburg Altona has wrong evaId #10

Closed lightsprint09 closed 6 years ago

lightsprint09 commented 6 years ago

Hamburg Altona displays not the main evaId.

We get 8002553 but expect 8098553.

derhuerst commented 6 years ago

The parsing script picks the isMain EVA ID. Is that wrong?

lightsprint09 commented 6 years ago

It is not wrong. But it seems to pick not main sometimes

derhuerst commented 6 years ago

Whenever there's no isMain, it will pick the first one.

derhuerst commented 6 years ago

Turns out that, after a rebuild, db-stations will pick 8098553 as the main EVA ID.

cd db-stations
env API_TOKEN=… npm run build
cat full.ndjson | grep Altona
{
    "type": "station",
    "id": "8098553",
    "ds100": "AA",
    "nr": 2517,
    "name": "Hamburg-Altona",
    "coordinates": {
        "latitude": 53.552695,
        "longitude": 9.935175
    },
    "operator": {
        "type": "operator",
        "id": "hamburger-verkehrsverbund-gmbh",
        "name": "BWVI"
    },
    "address": {
        "city": "Hamburg",
        "zipcode": "22765",
        "street": "Scheel-Plessen-Str. 17"
    },
    "category": 1,
    "priceCategory": 1,
    "hasParking": true,
    "hasBicycleParking": true,
    "hasLocalPublicTransport": true,
    "hasPublicFacilities": true,
    "hasLockerSystem": true,
    "hasTaxiRank": true,
    "hasTravelNecessities": true,
    "hasSteplessAccess": "yes",
    "hasMobilityService": "Ja, um Voranmeldung unter 01806 512 512 wird gebeten",
    "hasWiFi": true,
    "hasTravelCenter": true,
    "hasRailwayMission": true,
    "hasDBLounge": false,
    "hasLostAndFound": true,
    "hasCarRental": true,
    "federalState": "Hamburg",
    "regionalbereich": {
        "number": 3,
        "name": "RB Nord",
        "shortName": "RB N"
    },
    "DBinformation": {
        "availability": {
            "monday": {
                "fromTime": "06:00",
                "toTime": "22:30"
            },
            "tuesday": {
                "fromTime": "06:00",
                "toTime": "22:30"
            },
            "wednesday": {
                "fromTime": "06:00",
                "toTime": "22:30"
            },
            "thursday": {
                "fromTime": "06:00",
                "toTime": "22:30"
            },
            "friday": {
                "fromTime": "06:00",
                "toTime": "22:30"
            },
            "saturday": {
                "fromTime": "06:00",
                "toTime": "22:30"
            },
            "sunday": {
                "fromTime": "06:00",
                "toTime": "22:30"
            },
            "holiday": {
                "fromTime": "06:00",
                "toTime": "22:30"
            }
        }
    },
    "localServiceStaff": {
        "availability": {
            "monday": {
                "fromTime": "06:00",
                "toTime": "22:00"
            },
            "tuesday": {
                "fromTime": "06:00",
                "toTime": "22:00"
            },
            "wednesday": {
                "fromTime": "06:00",
                "toTime": "22:00"
            },
            "thursday": {
                "fromTime": "06:00",
                "toTime": "22:00"
            },
            "friday": {
                "fromTime": "06:00",
                "toTime": "22:00"
            },
            "saturday": {
                "fromTime": "06:00",
                "toTime": "22:00"
            },
            "sunday": {
                "fromTime": "06:00",
                "toTime": "22:00"
            },
            "holiday": {
                "fromTime": "06:00",
                "toTime": "22:00"
            }
        }
    },
    "timeTableOffice": {
        "email": "DBS.Fahrplan.HambSchleswHolstein@deutschebahn.com",
        "name": "Bahnhofsmanagement Hamburg"
    },
    "szentrale": {
        "number": 1,
        "publicPhoneNumber": "040-3918-1 053",
        "name": "Hamburg Hbf"
    },
    "stationManagement": {
        "number": 1,
        "name": "Hamburg"
    },
    "ril100Identifiers": [
        {
            "rilIdentifier": "AA",
            "isMain": true,
            "hasSteamPermission": true,
            "geographicCoordinates": {
                "type": "Point",
                "coordinates": [
                    9.934858047,
                    53.55257911
                ]
            }
        },
        {
            "rilIdentifier": "AAS",
            "isMain": false,
            "hasSteamPermission": false,
            "geographicCoordinates": {
                "type": "Point",
                "coordinates": [
                    9.934566886,
                    53.551233586
                ]
            }
        }
    ]
}
lightsprint09 commented 6 years ago

ok?

derhuerst commented 6 years ago

The Travis CI build is almost done, after that the npm package should contain the latest data.

lightsprint09 commented 6 years ago

Ok great! I will check and close the ticket if it works 👍

lightsprint09 commented 6 years ago

Oh. Now I see.

It seems that db-hafas uses not the main evaId

derhuerst commented 6 years ago

Ok, let's continue this over at db-hafas. Would you mind to open a new ticket with more specific details? 😉

lightsprint09 commented 6 years ago

sure