implement /stops - Githubissues

derhuerst / hafas-linked-connections-server

[work in progress] – Create a Linked Connections endpoint from a HAFAS client.

https://github.com/derhuerst/hafas-linked-connections-server#hafas-linked-connections-server

ISC License

6 stars 0 forks source link

implement /stops #3

Closed derhuerst closed 4 years ago

derhuerst commented 4 years ago

closes #1

@pietercolpaert What do you think?

derhuerst commented 4 years ago

Build is failing because there are no tests. 🙈

pietercolpaert commented 4 years ago

First sight of the code: looks great!

Give me a bit more time to test and check this though -- busy period :)

pietercolpaert commented 4 years ago

Approved changes: still some issues with it, but @hdelva will open a separate pull request for this!

Issues:

[ ] context is not complete: longitude, latitude and name need to be mapped to the right URIs
[ ] the URI parameter for departure time filtering is based on a timestamp. We expect an xsd:dateTime (ISO8601 subset). We agree this should’ve been better documented

derhuerst commented 4 years ago

We expect an xsd:dateTime (ISO8601 subset).

AFAICT it doesn't require a timezone (offset) designator (just like ISO 8601). I'd like to make this required, as using local time (a.k.a. wall clock time) without tz information is ambiguous and problematic given that Linked Connections aims for federation of large public transportation networks.