Bump ics to v3

[apriljunge]

Bumps ics dependecy to v3 This would solve seebruecke-events-calendar-feed#7

Removed custom calendar name defintion as this is now supported by ics package itself (ics@2.22.0)

[socket-security[bot]]

New dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary

Issue	Status
Install scripts	✅ 0 issues
Native code	✅ 0 issues
Bin script shell injection	✅ 0 issues
Unresolved require	✅ 0 issues
Invalid package.json	✅ 0 issues
HTTP dependency	✅ 0 issues
Git dependency	✅ 0 issues
Potential typo squat	✅ 0 issues
Known Malware	✅ 0 issues
Telemetry	✅ 0 issues
Protestware/Troll package	✅ 0 issues

📊 Modified Dependency Overview:

⬆️ Updated Package	Version Diff	Capability Access	+/- Transitive Count	Publisher
ics@3.1.0	2.44.0...3.1.0	None	+0/-0	adamgibbons

[apriljunge]

Because I changed the definition of the calendar name, it is only passed if events exist. Because of the way the ics library works, the calendar name would be missing if zero events are passed. Should I therefore undo the change?

[derhuerst]

Because I changed the definition of the calendar name, it is only passed if events exist. Because of the way the ics library works, the calendar name would be missing if zero events are passed. Should I therefore undo the change?

If I read the (ics-service) code correctly, the X-WR-CALNAME:${title} insertion only happens if ics contains METHOD:PUBLISH, which only happens if there are >0 events? If that's true, then we should rather make sure (by also adding a test) that a calendar name is always being added (or rather, that a non-empty calendar is always being generated, see also https://github.com/derhuerst/seebruecke-events-calendar-feed/issues/7).

[apriljunge]

Since the calendar name can only be passed via the events array (and when there are no events the array is empty), I will undo the change

[apriljunge]

@derhuerst Is there anything I could do to get this merged? It would help to close https://github.com/derhuerst/seebruecke-events-calendar-feed/issues/7 :smile:

[derhuerst]

Other than a test, I guess not. Let's merge this anyways.

[derhuerst]

Published as ics-service@1.3.0.