search

derhuerst / node-sockopt

getsockopt & setsockopt for Node.js sockets.
https://github.com/derhuerst/node-sockopt#sockopt
ISC License
8 stars 2 forks source link

handle non-integer flags #1

Open derhuerst opened 4 years ago

derhuerst commented 4 years ago

From https://github.com/derhuerst/node-sockopt/blob/19410b3a048efa3bbb3f955e677e438bbdc6104d/index.js#L21-L25:

Currently _setsockopt (& _getsockopt) only handles integers. todo: fails with e.g. SO_RCVTIMEO/SO_SNDTIMEO

if (!Number.isInteger(flagValue)) {
  throw new Error('flagValue must be an integer')
}

The native code would have to be adapted to create the appropriate structs for selected flags.

derhuerst commented 4 years ago

This could be done using shared-structs.