derhuerst / parse-gml-polygon

Convert a GML Polygon into GeoJSON.
https://github.com/derhuerst/parse-gml-polygon
ISC License
11 stars 2 forks source link

Discussion: implement parsing other geometry types in this project and then optionally split #13

Open highsource opened 6 years ago

highsource commented 6 years ago

I would like to continue working on gml-to-geojson i.e. parsing further geometry types.

After some consideration I have come to the conclusion that it will probably be easier to implement parsing further geometry types in this project first and then optionally split non-polygon stuff into a different project.

There are way too many intersections so I think that ultimately there will be no big difference between parse-gml-polygon and gml-to-geojson. We need parsing of points, line strings or linear rings etc. here as well.

Suggestion: I would like to create a gml-to-geojson branch here and continue with further geometry types on this branch. I'll keep in mind that code should be easily splittable. Finally we'll evaluate if it is worth splitting or extracting non-polygon stuff into a separate project.

What do you think?

derhuerst commented 6 years ago

I'm fine with a branch. Once we/you have implemented more, we might also think about moving common parts into a lib (points, line strings or linear rings etc.).