search

derhuerst / parse-gml-polygon

Convert a GML Polygon into GeoJSON.
https://github.com/derhuerst/parse-gml-polygon
ISC License
11 stars 2 forks source link

Refactor function signatures to (data, opts, ctx) #4

Closed highsource closed 6 years ago

highsource commented 6 years ago

As discussed in derhuerst/wfs-gml-to-geojson#3, let us refactor function signatures to function signatures to (data, ctx, opts).

I'll do the work on a branch in https://github.com/highsource/parse-gml-polygon and send a PR.

This is a breaking change so we have to pump the major version.

highsource commented 6 years ago

@derhuerst By the way I think you were right about (data, opts, ctx) vs. (data, ctx, opts). The signature (data, opts, ctx) feels better. The end-user will probably more often need to specify opts than ctx.